Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754872AbbEZNee (ORCPT ); Tue, 26 May 2015 09:34:34 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:36456 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751569AbbEZNe3 (ORCPT ); Tue, 26 May 2015 09:34:29 -0400 Date: Tue, 26 May 2015 14:34:23 +0100 From: Lee Jones To: Tomeu Vizoso Cc: Sascha Hauer , Mark Rutland , linux-fbdev@vger.kernel.org, Jingoo Han , Tomi Valkeinen , Dmitry Torokhov , "linux-kernel@vger.kernel.org" , Rob Herring , =?iso-8859-1?Q?St=E9phane?= Marchesin , Thierry Reding , Grant Likely , Alexander Holler , Jean-Christophe Plagniol-Villard , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 15/21] backlight: Probe backlight devices on demand Message-ID: <20150526133423.GK11677@x1> References: <1432565608-26036-1-git-send-email-tomeu.vizoso@collabora.com> <1432565608-26036-16-git-send-email-tomeu.vizoso@collabora.com> <20150526071850.GA11677@x1> <20150526072526.GB6325@pengutronix.de> <20150526083931.GC11677@x1> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2553 Lines: 62 On Tue, 26 May 2015, Tomeu Vizoso wrote: > On 26 May 2015 at 10:39, Lee Jones wrote: > > On Tue, 26 May 2015, Sascha Hauer wrote: > >> On Tue, May 26, 2015 at 08:18:50AM +0100, Lee Jones wrote: > >> > On Mon, 25 May 2015, Tomeu Vizoso wrote: > >> > > >> > > When looking up a backlight device through its DT node, ensure that the > >> > > corresponding device has been registered. > >> > > > >> > > Signed-off-by: Tomeu Vizoso > >> > > --- > >> > > drivers/video/backlight/backlight.c | 3 +++ > >> > > 1 file changed, 3 insertions(+) > >> > > >> > Looks reasonable. > >> > > >> > Until anyone screams at me, applied thanks. > >> > >> The compiler will scream at you when it realizes that > >> of_platform_device_ensure() doesn't exist in your kernel... > > > > Yup, indeed it did. > > > > I assumed this was *only* enabling subsystems and that the > > framework/API was already accepted. > > > > So the advice I'd give to Tomeu when sending full enablement > > patch-sets i.e. ones which provide the framework/API *and* enable > > subsystems in the same set, is to send the entire set to everyone, so > > we can see what the aim of the set is and how to deal with it. > > Yeah, but get_maintainer.pl outputs 33 maintainer addresses, plus 1 > reviewer plus 14 mailing lists, so to avoid rejects because of too > many recipients I went with the advice in [0] and sent each patch to > their maintainers and list(s) and the cover letter to all lists. Also > sent the whole series to lakml to make sure that it's at least indexed > there. Mails aren't usually rejected because they have too many recipients, rather they require approval. This isn't a blocker, especially for patch-sets like this. > Any advice on what to do with series that span so many subsystems? I would either ensure everyone is informed, split into two choices; either CC everyone on every patch, or at least everyone on the cover-letter and the core API changes. The other method is to have the API changes accepted first, then once accepted send out the subsystem changes [FWIW: this is the method I (wrongly) assumed you used]. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/