Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754541AbbEZN4X (ORCPT ); Tue, 26 May 2015 09:56:23 -0400 Received: from mail-wg0-f54.google.com ([74.125.82.54]:35134 "EHLO mail-wg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753144AbbEZN4V (ORCPT ); Tue, 26 May 2015 09:56:21 -0400 Date: Tue, 26 May 2015 14:56:16 +0100 From: Lee Jones To: Charles Keepax Cc: sameo@linux.intel.com, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org, dan.carpenter@oracle.com Subject: Re: [PATCH v2] mfd: arizona: Add missing braces Message-ID: <20150526135616.GM11677@x1> References: <1432048931-2287-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1432048931-2287-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1730 Lines: 55 On Tue, 19 May 2015, Charles Keepax wrote: > Some braces were missing from commit 67f0b1133d55 ("mfd: arizona: > Add better support for system suspend"). This will cause the error check > to run even if the register write didn't happen (although ret will > always be zero so it is harmless). This patch adds the missing > braces. > > Reported-by: Dan Carpenter > Signed-off-by: Charles Keepax > --- > > Changes since v1: > - Corrected braino in commit message (parenthesis -> braces) > > Thanks, > Charles > > drivers/mfd/arizona-core.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) Fixed-up into the original patch. > diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c > index 5caf579..bebf58a 100644 > --- a/drivers/mfd/arizona-core.c > +++ b/drivers/mfd/arizona-core.c > @@ -626,7 +626,7 @@ static int arizona_runtime_suspend(struct device *dev) > } > break; > case WM5102: > - if (!(val & ARIZONA_JD1_ENA)) > + if (!(val & ARIZONA_JD1_ENA)) { > ret = regmap_write(arizona->regmap, > ARIZONA_WRITE_SEQUENCER_CTRL_3, 0x0); > if (ret) { > @@ -635,6 +635,7 @@ static int arizona_runtime_suspend(struct device *dev) > ret); > return ret; > } > + } > break; > default: > break; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/