Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754883AbbEZODd (ORCPT <rfc822;w@1wt.eu>);
	Tue, 26 May 2015 10:03:33 -0400
Received: from vi37-28-154-113.vibiznes.pl ([37.28.154.113]:53277 "EHLO
	vps-vb.mhejs.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751947AbbEZODb (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 26 May 2015 10:03:31 -0400
Message-ID: <55647D25.80807@maciej.szmigiero.name>
Date: Tue, 26 May 2015 16:03:17 +0200
From: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0
MIME-Version: 1.0
To: Takashi Iwai <tiwai@suse.de>
CC: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        patches@opensource.wolfsonmicro.com,
        Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>, Lars-Peter Clausen <lars@metafoo.de>,
        Daniel Mack <daniel@zonque.org>, Wolfram Sang <wsa@the-dreams.de>,
        Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
        Matt Reimer <mreimer@sdgsystems.com>
Subject: Re: [PATCH] ASoC: codecs: use SNDRV_PCM_FMTBIT_* for format bitmask
References: <5560AB9D.1010807@maciej.szmigiero.name> <s5h382j29ey.wl-tiwai@suse.de>
In-Reply-To: <s5h382j29ey.wl-tiwai@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1886
Lines: 51

Hello Takashi,

W dniu 26.05.2015 07:29, Takashi Iwai pisze:
> At Sat, 23 May 2015 18:32:29 +0200,
> Maciej S. Szmigiero wrote:
>>
>> snd_soc_pcm_stream.formats is a bitmask of SNDRV_PCM_FMTBIT_*,
>> not of SNDRV_PCM_FORMAT_* (which are sequential integers),
>> however some of ASoC CODEC drivers use these values instead.
>>
>> Found out by sparse on 0-day kernel tester.
>>
>> Signed-off-by: Maciej Szmigiero <mail@maciej.szmigiero.name>
> 
> Wow, that made me wonder how these drivers could actually work.

Maybe, by coincidence, the wrong defines contained enough bits
set to actually select some common, working format with their
controllers?

> BTW, how did you detect it?  Any static analyzer like sparse or
> smatch?  sparse didn't detect it at the last time I tried, IIRC...

I've received an e-mail from "kbuild test robot" at
"0-DAY kernel test infrastructure" that automated testing there
using sparse found this issue on wm9713 and stac9766 CODECs.

The exact warning was:
>> sound/soc/codecs/stac9766.c:324:28: sparse: incorrect type in initializer (different base types)
   sound/soc/codecs/stac9766.c:324:28:    expected unsigned long long [unsigned] [usertype] formats
   sound/soc/codecs/stac9766.c:324:28:    got restricted snd_pcm_format_t [usertype] <noident>

What is important the warning doesn't show unless a check build
is made with CF=-D__CHECK_ENDIAN__ .

Upon checking I've found the same issue also in two other CODECs,
which aren't normally being built on x86_64 (target architecture
for above automated build) even when SND_SOC_ALL_CODECS is selected.

> thanks,
> 
> Takashi

Best regards,
Maciej Szmigiero

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/