From: "Opensource [Steve Twiss]" <stwiss.opensource@diasemi.com>
To: Lee Jones <lee.jones@linaro.org>,
        "Opensource [Steve Twiss]" <stwiss.opensource@diasemi.com>
CC: Samuel Ortiz <sameo@linux.intel.com>, DT <devicetree@vger.kernel.org>,
        David Dajun Chen <david.chen@diasemi.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        INPUT <linux-input@vger.kernel.org>,
        "Ian Campbell" <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, LKML <linux-kernel@vger.kernel.org>,
        Mark Rutland <mark.rutland@arm.com>, Pawel Moll <pawel.moll@arm.com>,
        Rob Herring <robh+dt@kernel.org>,
        "Support Opensource" <Support.Opensource@diasemi.com>
Subject: RE: [RESEND PATCH V4 3/3] mfd: da9063: MFD support for OnKey driver
Thread-Topic: [RESEND PATCH V4 3/3] mfd: da9063: MFD support for OnKey driver
Thread-Index: AQHQkh+AIiDgJ7oLLk27mZIkSOv+M52OQtOAgAASzeA=
Date: Tue, 26 May 2015 14:06:46 +0000
Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7014B22CC3F@SW-EX-MBX02.diasemi.com>
References: <cover.1432031565.git.stwiss.opensource@diasemi.com>
 <a508f5d715e94fb18e6ef4ce755c2225a17090ea.1432031565.git.stwiss.opensource@diasemi.com>
 <20150526135735.GN11677@x1>
In-Reply-To: <20150526135735.GN11677@x1>
Accept-Language: en-GB, en-US
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 2213
Lines: 65


On 26 May 2015 14:58 Lee Jones wrote:

> To: Opensource [Steve Twiss]
> Cc: Samuel Ortiz; DT; David Dajun Chen; Dmitry Torokhov; INPUT; Ian
> Campbell; Kumar Gala; LKML; Mark Rutland; Pawel Moll; Rob Herring;
> Support Opensource
> Subject: Re: [RESEND PATCH V4 3/3] mfd: da9063: MFD support for OnKey
> driver
> 
> On Tue, 19 May 2015, S Twiss wrote:
> 
> > From: Steve Twiss <stwiss.opensource@diasemi.com>
> >
> > Add MFD support for the DA9063 OnKey driver
> >
> > The function da9063_clear_fault_log() is added to mitigate the case of a
> > hardware power-cut after a long-long OnKey press. Although there is no
> > software intervention in this case (by definition) such a shutdown would
> > cause persistent information within the DA9063 FAULT_LOG that would be
> > available during the next device restart.
> >
> > Clearance of this persistent register must be completed after such a
> > hardware power-cut operation has happened so that the FAULT_LOG does not
> > continue with previous values. The clearance function has been added here
> > in the kernel driver because wiping the fault-log cannot be counted on
> > outside the Linux kernel.
> >
> > Acked-by: Lee Jones <lee.jones@linaro.org>
> >
> > Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>
> >
> > ---
> > Version History
> >
> > Changes in V4
> >  - Additional description of MFD patch changes for FAULT_LOG in relation to
> >    the requirements of the OnKey driver. Please see a further explanation of
> >    the OnKey's operation in this thread: https://lkml.org/lkml/2015/4/29/406
> >
> > Changes in V3
> >  - The MFD code was originally in [PATCH V2 1/2]. This is now been moved into
> >    this patch [PATCH V3 3/3].
> >  - Whitespace cleanup
> >
> > This patch applies against linux-next and v4.1-rc3
> >
> >
> >  drivers/mfd/da9063-core.c        | 54
> ++++++++++++++++++++++++++++++++++++++++
> >  include/linux/mfd/da9063/pdata.h |  1 +
> >  2 files changed, 55 insertions(+)
> 
> Applied, thanks.
> 

Thank you
Regards,
Steve

ps.
and also for DT patch

[...]
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?