Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932496AbbEZOWs (ORCPT ); Tue, 26 May 2015 10:22:48 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:47627 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932366AbbEZOWl (ORCPT ); Tue, 26 May 2015 10:22:41 -0400 Date: Tue, 26 May 2015 09:19:38 -0500 From: Felipe Balbi To: Arun Ramamurthy CC: , Jonathan Corbet , Tejun Heo , Kyungmin Park , Sylwester Nawrocki , Mauro Carvalho Chehab , Kukjin Kim , Kishon Vijay Abraham I , Greg Kroah-Hartman , Alan Stern , Tony Prisk , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Arnd Bergmann , Mathias Nyman , Paul Bolle , Thomas Pugliese , Srinivas Kandagatla , Masanari Iida , David Mosberger , Peter Griffin , Gregory CLEMENT , Laurent Pinchart , Kevin Hao , Jean Delvare , , , , , , , , , Dmitry Torokhov , Anatol Pomazau , Jonathan Richardson , Scott Branden , Ray Jui , Subject: Re: [PATCHv3 1/4] phy: phy-core: Make GENERIC_PHY an invisible option Message-ID: <20150526141938.GA25686@saruman.tx.rr.com> Reply-To: References: <1429743853-10254-1-git-send-email-arun.ramamurthy@broadcom.com> <1429743853-10254-2-git-send-email-arun.ramamurthy@broadcom.com> <20150515005210.GA31534@saruman.tx.rr.com> <556391FE.1020503@broadcom.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="EeQfGwPcQSOJBaQU" Content-Disposition: inline In-Reply-To: <556391FE.1020503@broadcom.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5025 Lines: 139 --EeQfGwPcQSOJBaQU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable HI, On Mon, May 25, 2015 at 02:19:58PM -0700, Arun Ramamurthy wrote: >=20 >=20 > On 15-05-14 05:52 PM, Felipe Balbi wrote: > >Hi, > > > >On Wed, Apr 22, 2015 at 04:04:10PM -0700, Arun Ramamurthy wrote: > >>Most of the phy providers use "select" to enable GENERIC_PHY. Since sel= ect > >>is only recommended when the config is not visible, GENERIC_PHY is chan= ged > >>an invisible option. To maintain consistency, all phy providers are cha= nged > >>to "select" GENERIC_PHY and all non-phy drivers use "depends on" when t= he > >>phy framework is explicity required. USB_MUSB_OMAP2PLUS has a cyclic > >>dependency, so it is left as "select". > >> > >>Signed-off-by: Arun Ramamurthy > >>--- > >> drivers/ata/Kconfig | 1 - > >> drivers/media/platform/exynos4-is/Kconfig | 2 +- > >> drivers/phy/Kconfig | 4 ++-- > >> drivers/usb/host/Kconfig | 4 ++-- > >> drivers/video/fbdev/exynos/Kconfig | 2 +- > >> 5 files changed, 6 insertions(+), 7 deletions(-) > >> > >>diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig > >>index 5f60155..6d2e881 100644 > >>--- a/drivers/ata/Kconfig > >>+++ b/drivers/ata/Kconfig > >>@@ -301,7 +301,6 @@ config SATA_MV > >> tristate "Marvell SATA support" > >> depends on PCI || ARCH_DOVE || ARCH_MV78XX0 || \ > >> ARCH_MVEBU || ARCH_ORION5X || COMPILE_TEST > >>- select GENERIC_PHY > >> help > >> This option enables support for the Marvell Serial ATA family. > >> Currently supports 88SX[56]0[48][01] PCI(-X) chips, > >>diff --git a/drivers/media/platform/exynos4-is/Kconfig b/drivers/media/= platform/exynos4-is/Kconfig > >>index b7b2e47..b6f3eaa 100644 > >>--- a/drivers/media/platform/exynos4-is/Kconfig > >>+++ b/drivers/media/platform/exynos4-is/Kconfig > >>@@ -31,7 +31,7 @@ config VIDEO_S5P_FIMC > >> config VIDEO_S5P_MIPI_CSIS > >> tristate "S5P/EXYNOS MIPI-CSI2 receiver (MIPI-CSIS) driver" > >> depends on REGULATOR > >>- select GENERIC_PHY > >>+ depends on GENERIC_PHY > >> help > >> This is a V4L2 driver for Samsung S5P and EXYNOS4 SoC MIPI-CSI2 > >> receiver (MIPI-CSIS) devices. > >>diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > >>index 2962de2..edecdb1 100644 > >>--- a/drivers/phy/Kconfig > >>+++ b/drivers/phy/Kconfig > >>@@ -5,7 +5,7 @@ > >> menu "PHY Subsystem" > >> > >> config GENERIC_PHY > >>- bool "PHY Core" > >>+ bool > >> help > >> Generic PHY support. > >> > >>@@ -72,7 +72,7 @@ config PHY_MIPHY365X > >> config PHY_RCAR_GEN2 > >> tristate "Renesas R-Car generation 2 USB PHY driver" > >> depends on ARCH_SHMOBILE > >>- depends on GENERIC_PHY > >>+ select GENERIC_PHY > > > >so some you changed from depends to select... > > > >> help > >> Support for USB PHY found on Renesas R-Car generation 2 SoCs. > >> > >>diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig > >>index 5ad60e4..e2197e2 100644 > >>--- a/drivers/usb/host/Kconfig > >>+++ b/drivers/usb/host/Kconfig > >>@@ -182,7 +182,7 @@ config USB_EHCI_HCD_SPEAR > >> config USB_EHCI_HCD_STI > >> tristate "Support for ST STiHxxx on-chip EHCI USB controller" > >> depends on ARCH_STI && OF > >>- select GENERIC_PHY > >>+ depends on GENERIC_PHY > > > >while others you changed from select to depends. > > > >NAK. > > > Felipe, I dont understand your concern, could you please explain it more > detail? The logic behind the changes is that in cases where there was an > explicit dependency, I changed it to "depends on" and in other cases I > changed it to "selects". Thanks Since GENERIC_PHY is visible from Kconfig, it would be much nicer to avoid select altogether. --=20 balbi --EeQfGwPcQSOJBaQU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVZID6AAoJEIaOsuA1yqRE0+UP/0gbRn3HOB1oVrDwtf6TrBF7 nqy4eIn+elJ6u7cUkjzPIAlOhBl0PVcvtOCKhdOjvp70+7N+mBkBRdG99AtnT/i3 B8gc+r82CA9o3fVOXF86S6ITL1L1BgrjSnHh6FTa33qHa2HxIrT5vQ6BpOtULiaR /l5nDxlYSr8joHSPCSM5W+994eymt0ia1CfXXuWXTs60wifLavbbGQwSCk8aI08e 1uP833zksOmx/NUENEDS06a1kfAYaYxOdm4EcBzLbdeWCUaW8kAmkZiWXYEUdEgn no+PbWxc9INWiL/NsuW4PQqKjo7mpXRzVaTaXS7b+evW2tW6NwvcBObI59K7xPxw egphn3dTmJuxXvWGH/xw6RgCcies5IJkFI7IM5wWqcHoGi6zoG946kijBXqMVVdh zIxc4YqausiV9whMdJfqnq9THg5/X3UtvqP9GKtO4E39hwrVS8RCbODfMNVE9H6d gHGVTzX5yrTHSa/Fjv61X/KLvD8lYVK90xftibci7JlYmq842LfUQT7E1950oR5m aNS20Vdj8F/wKisptf2T3iSZbb2sCgC+GEuSFwkyrLYxqWKmn2VAXhDloUJX/aOf uTyBtX6xYr3szM/EleRbDCJo72rRzeo2asn9NP67/6wrVU4G11MMS3733Bj0vbjl xr1VzQKX555V0ct2q7KP =zfwd -----END PGP SIGNATURE----- --EeQfGwPcQSOJBaQU-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/