Message-ID: <55648374.80802@sandisk.com>
Date: Tue, 26 May 2015 16:30:12 +0200
From: Bart Van Assche <bart.vanassche@sandisk.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: "Nicholas A. Bellinger" <nab@daterainc.com>,
        target-devel <target-devel@vger.kernel.org>
CC: linux-scsi <linux-scsi@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Christoph Hellwig <hch@lst.de>, "Hannes Reinecke" <hare@suse.de>,
        Sagi Grimberg <sagig@mellanox.com>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Nicholas Bellinger <nab@linux-iscsi.org>
Subject: Re: [PATCH-v2 2/4] target: Drop lun_sep_lock for se_lun->lun_se_dev
 RCU usage
References: <1432623445-25776-1-git-send-email-nab@daterainc.com>
 <1432623445-25776-3-git-send-email-nab@daterainc.com>
In-Reply-To: <1432623445-25776-3-git-send-email-nab@daterainc.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2015 14:30:16.5010
 (UTC)
X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.173];Helo=[milsmgep12.sandisk.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0201MB1028
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2102
Lines: 50

On 05/26/15 08:57, Nicholas A. Bellinger wrote:
> @@ -625,6 +626,7 @@ int core_dev_add_initiator_node_lun_acl(
>   	u32 lun_access)
>   {
>   	struct se_node_acl *nacl = lacl->se_lun_nacl;
> +	struct se_device *dev = lockless_dereference(lun->lun_se_dev);
>   
>   	if (!nacl)
>   		return -EINVAL;

An attempt to run this code on a system with RCU debugging enabled
resulted in the following complaint:

===============================
[ INFO: suspicious RCU usage. ]
4.1.0-rc1-lio-dbg+ #1 Not tainted
-------------------------------
drivers/target/target_core_device.c:617 suspicious rcu_dereference_check() usage!

other info that might help us debug this:


rcu_scheduler_active = 1, debug_locks = 1
2 locks held by ln/1497:
 #0:  (sb_writers#11){.+.+.+}, at: [<ffffffff811d9ca4>] mnt_want_write+0x24/0x50
 #1:  (&sb->s_type->i_mutex_key#14/1){+.+.+.}, at: [<ffffffff811c4cdd>] filename_create+0xad/0x1a0

stack backtrace:
CPU: 0 PID: 1497 Comm: ln Not tainted 4.1.0-rc1-lio-dbg+ #1
Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011
 0000000000000001 ffff88005955bd68 ffffffff814fa346 0000000000000011
 ffff880058bf1270 ffff88005955bd98 ffffffff810ab235 ffff880050db9a68
 ffff880058ae2e68 0000000000000002 ffff880058ae4120 ffff88005955be08
Call Trace:
 [<ffffffff814fa346>] dump_stack+0x4f/0x7b
 [<ffffffff810ab235>] lockdep_rcu_suspicious+0xd5/0x110
 [<ffffffffa04324bc>] core_dev_add_initiator_node_lun_acl+0xec/0x190 [target_core_mod]
 [<ffffffff8108f871>] ? get_parent_ip+0x11/0x50
 [<ffffffffa04346f9>] target_fabric_mappedlun_link+0x129/0x240 [target_core_mod]
 [<ffffffffa043466c>] ? target_fabric_mappedlun_link+0x9c/0x240 [target_core_mod]
 [<ffffffffa035824d>] configfs_symlink+0x13d/0x360 [configfs]
 [<ffffffff811be8c8>] vfs_symlink+0x58/0xb0
 [<ffffffff811c75c5>] SyS_symlink+0x65/0xc0
 [<ffffffff81502eb2>] system_call_fastpath+0x16/0x7a

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/