Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752900AbbEZOpT (ORCPT ); Tue, 26 May 2015 10:45:19 -0400 Received: from nbfkord-smmo04.seg.att.com ([209.65.160.86]:16470 "EHLO nbfkord-smmo04.seg.att.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751922AbbEZOpP (ORCPT ); Tue, 26 May 2015 10:45:15 -0400 X-MXL-Hash: 556486fa7b76c0e3-5b4a38cb3290c99cde4bb471cfd1dc06cc6d793e Message-ID: <556486F3.5020007@solarflare.com> Date: Tue, 26 May 2015 15:45:07 +0100 From: Edward Cree User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Bandan Das CC: Xiao Guangrong , , , , , Subject: Re: [PATCH 1/2] KVM: MMU: fix SMAP virtualization References: In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.17.20.45] X-TM-AS-Product-Ver: SMEX-10.0.0.1412-7.000.1014-21570.005 X-TM-AS-Result: No--6.000400-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-AnalysisOut: [v=2.0 cv=I4vSsqcg c=1 sm=1 a=MkjXnYnS3dyNWGSWLXxFFQ==:17 a] X-AnalysisOut: [=mypmul4OXYAA:10 a=fVG4DLb5TBsA:10 a=BLceEmwcHowA:10 a=Ikc] X-AnalysisOut: [TkHD0fZMA:10 a=zRKbQ67AAAAA:8 a=h1PgugrvaO0A:10 a=mDV3o1hI] X-AnalysisOut: [AAAA:8 a=POIEbU6OcBsUhXtn2zAA:9 a=QEXdDO2ut3YA:10] X-Spam: [F=0.2000000000; CM=0.500; S=0.200(2014051901)] X-MAIL-FROM: X-SOURCE-IP: [12.187.104.25] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 953 Lines: 19 >> This breaks older compilers that can't initialize anon structures. > > How old ? Even gcc 3.1 says you can use unnamed struct/union fields and > 3.2 is the minimum version required to compile the kernel as mentioned > in the README. > > We could simply just name the structure, but I doubt this is the > only place in the kernel code where it's being used this way :) This appears to be GCC bug #10676, see Says it was fixed in 4.6, but I believe the kernel supports GCCs much older than that (back to 3.2). I personally hit it on 4.4.7, the version shipped with RHEL6.6. So I think the kernel code has to change, probably by naming the structure. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/