Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756130AbbEZQ6x (ORCPT ); Tue, 26 May 2015 12:58:53 -0400 Received: from eu-smtp-delivery-143.mimecast.com ([207.82.80.143]:62343 "EHLO eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756114AbbEZQ6s convert rfc822-to-8bit (ORCPT ); Tue, 26 May 2015 12:58:48 -0400 Date: Tue, 26 May 2015 17:58:44 +0100 From: Liviu Dudau To: Hanjun Guo Cc: Bjorn Helgaas , Arnd Bergmann , Catalin Marinas , Will Deacon , "Rafael J. Wysocki" , Jiang Liu , Thomas Gleixner , Yijing Wang , Lorenzo Pieralisi , Tomasz Nowicki , "suravee.suthikulpanit@amd.com" , "msalter@redhat.com" , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linaro-acpi@lists.linaro.org" Subject: Re: [PATCH 01/11] ARM64 / PCI: introduce struct pci_controller for ACPI Message-ID: <20150526165844.GD2175@e106497-lin.cambridge.arm.com> References: <1432644564-24746-1-git-send-email-hanjun.guo@linaro.org> <1432644564-24746-2-git-send-email-hanjun.guo@linaro.org> MIME-Version: 1.0 In-Reply-To: <1432644564-24746-2-git-send-email-hanjun.guo@linaro.org> User-Agent: Mutt/1.5.22 (2013-10-16) X-OriginalArrivalTime: 26 May 2015 16:58:44.0969 (UTC) FILETIME=[39F15590:01D097D5] X-MC-Unique: _ZMbQbc0T3Gb8-xW3kQ0uA-1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2091 Lines: 72 On Tue, May 26, 2015 at 01:49:14PM +0100, Hanjun Guo wrote: > ARM64 ACPI based PCI host bridge init needs a arch dependent > struct pci_controller to accommodate common PCI host bridge > code which is introduced later, or it will lead to compile > errors on ARM64. Hi Hanjun, Two questions: why don't you introduce this patch next to the one that is going to make use of it (or even merge it there)? Second, why is the whole struct pci_controller not surrounded by #ifdef CONFIG_ACPI as you are implying that this is needed only for ACPI? Btw, looking through the whole series I'm not (yet) convinced that this is needed at all. Best regards, Liviu > > Signed-off-by: Hanjun Guo > Tested-by: Suravee Suthikulpanit > CC: Arnd Bergmann > CC: Catalin Marinas > CC: Liviu Dudau > CC: Lorenzo Pieralisi > CC: Will Deacon > --- > arch/arm64/include/asm/pci.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/include/asm/pci.h b/arch/arm64/include/asm/pci.h > index b008a72..7088495 100644 > --- a/arch/arm64/include/asm/pci.h > +++ b/arch/arm64/include/asm/pci.h > @@ -10,6 +10,16 @@ > #include > #include > > +struct acpi_device; > + > +struct pci_controller { > +#ifdef CONFIG_ACPI > + struct acpi_device *companion; /* ACPI companion device */ > +#endif > + int segment; /* PCI domain */ > + int node; /* NUMA node */ > +}; > + > #define PCIBIOS_MIN_IO 0x1000 > #define PCIBIOS_MIN_MEM 0 > > -- > 1.9.1 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/