Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752232AbbEZRI1 (ORCPT ); Tue, 26 May 2015 13:08:27 -0400 Received: from foss.arm.com ([217.140.101.70]:50622 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751491AbbEZRIZ (ORCPT ); Tue, 26 May 2015 13:08:25 -0400 Date: Tue, 26 May 2015 18:08:18 +0100 From: Will Deacon To: Hanjun Guo Cc: Bjorn Helgaas , Arnd Bergmann , Catalin Marinas , "Rafael J. Wysocki" , Jiang Liu , Liviu Dudau , Thomas Gleixner , Yijing Wang , Lorenzo Pieralisi , Tomasz Nowicki , "suravee.suthikulpanit@amd.com" , "msalter@redhat.com" , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linaro-acpi@lists.linaro.org" Subject: Re: [PATCH 05/11] x86, pci, acpi: Move arch-agnostic MMCONFIG (aka ECAM) and ACPI code out of arch/x86/ directory Message-ID: <20150526170817.GU1565@arm.com> References: <1432644564-24746-1-git-send-email-hanjun.guo@linaro.org> <1432644564-24746-6-git-send-email-hanjun.guo@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432644564-24746-6-git-send-email-hanjun.guo@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1677 Lines: 38 On Tue, May 26, 2015 at 01:49:18PM +0100, Hanjun Guo wrote: > From: Tomasz Nowicki > > ECAM standard and MCFG table are architecture independent and it makes > sense to share common code across all architectures. Both are going to > corresponding files - ecam.c and mcfg.c > > While we are here, rename pci_parse_mcfg to acpi_parse_mcfg. > We already have acpi_parse_mcfg prototype which is used nowhere. > At the same time, we need pci_parse_mcfg been global so acpi_parse_mcfg > can be used perfectly here. > > Signed-off-by: Tomasz Nowicki > Signed-off-by: Hanjun Guo > Tested-by: Suravee Suthikulpanit > --- > arch/x86/Kconfig | 3 + > arch/x86/include/asm/pci_x86.h | 33 ------ > arch/x86/pci/acpi.c | 1 + > arch/x86/pci/mmconfig-shared.c | 244 +--------------------------------------- > arch/x86/pci/mmconfig_32.c | 1 + > arch/x86/pci/mmconfig_64.c | 1 + > arch/x86/pci/numachip.c | 1 + > drivers/acpi/Makefile | 1 + > drivers/acpi/mcfg.c | 57 ++++++++++ > drivers/pci/Kconfig | 7 ++ > drivers/pci/Makefile | 5 + > drivers/pci/ecam.c | 245 +++++++++++++++++++++++++++++++++++++++++ Why can't we make use of the ECAM implementation used by pci-host-generic and drivers/pci/access.c? Will -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/