Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754336AbbEZRU5 (ORCPT ); Tue, 26 May 2015 13:20:57 -0400 Received: from mga11.intel.com ([192.55.52.93]:16279 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752281AbbEZRUv (ORCPT ); Tue, 26 May 2015 13:20:51 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,499,1427785200"; d="scan'208";a="735532758" Message-ID: <5564AB68.6080502@linux.intel.com> Date: Wed, 27 May 2015 01:20:40 +0800 From: Jiang Liu Organization: Intel User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Liviu Dudau , Hanjun Guo CC: Bjorn Helgaas , Arnd Bergmann , Catalin Marinas , Will Deacon , "Rafael J. Wysocki" , Thomas Gleixner , Yijing Wang , Lorenzo Pieralisi , Tomasz Nowicki , "suravee.suthikulpanit@amd.com" , "msalter@redhat.com" , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linaro-acpi@lists.linaro.org" Subject: Re: [PATCH 01/11] ARM64 / PCI: introduce struct pci_controller for ACPI References: <1432644564-24746-1-git-send-email-hanjun.guo@linaro.org> <1432644564-24746-2-git-send-email-hanjun.guo@linaro.org> <20150526165844.GD2175@e106497-lin.cambridge.arm.com> In-Reply-To: <20150526165844.GD2175@e106497-lin.cambridge.arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2243 Lines: 70 On 2015/5/27 0:58, Liviu Dudau wrote: > On Tue, May 26, 2015 at 01:49:14PM +0100, Hanjun Guo wrote: >> ARM64 ACPI based PCI host bridge init needs a arch dependent >> struct pci_controller to accommodate common PCI host bridge >> code which is introduced later, or it will lead to compile >> errors on ARM64. > > Hi Hanjun, > > Two questions: why don't you introduce this patch next to the > one that is going to make use of it (or even merge it there)? > Second, why is the whole struct pci_controller not surrounded > by #ifdef CONFIG_ACPI as you are implying that this is needed > only for ACPI? > > Btw, looking through the whole series I'm not (yet) convinced > that this is needed at all. Hi Liviu, This structure is required by the requested patch set at http://patchwork.ozlabs.org/patch/472249/, which consolidates the common code to support PCI host bridge into ACPI core. Thanks! Gerry > > Best regards, > Liviu > >> >> Signed-off-by: Hanjun Guo >> Tested-by: Suravee Suthikulpanit >> CC: Arnd Bergmann >> CC: Catalin Marinas >> CC: Liviu Dudau >> CC: Lorenzo Pieralisi >> CC: Will Deacon >> --- >> arch/arm64/include/asm/pci.h | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/arch/arm64/include/asm/pci.h b/arch/arm64/include/asm/pci.h >> index b008a72..7088495 100644 >> --- a/arch/arm64/include/asm/pci.h >> +++ b/arch/arm64/include/asm/pci.h >> @@ -10,6 +10,16 @@ >> #include >> #include >> >> +struct acpi_device; >> + >> +struct pci_controller { >> +#ifdef CONFIG_ACPI >> + struct acpi_device *companion; /* ACPI companion device */ >> +#endif >> + int segment; /* PCI domain */ >> + int node; /* NUMA node */ >> +}; >> + >> #define PCIBIOS_MIN_IO 0x1000 >> #define PCIBIOS_MIN_MEM 0 >> >> -- >> 1.9.1 >> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/