Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751408AbbEZS0i (ORCPT ); Tue, 26 May 2015 14:26:38 -0400 Received: from p3plex2out03.prod.phx3.secureserver.net ([184.168.131.16]:37899 "EHLO p3plex2out03.prod.phx3.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750835AbbEZS0f convert rfc822-to-8bit (ORCPT ); Tue, 26 May 2015 14:26:35 -0400 From: Hartley Sweeten To: Ian Abbott , "driverdev-devel@linuxdriverproject.org" CC: Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] staging: comedi: comedi_isadma.h: make self-reliant Thread-Topic: [PATCH] staging: comedi: comedi_isadma.h: make self-reliant Thread-Index: AQHQlLcc7tfEVPyNykuC6zIKt1igcp2OmOkA Date: Tue, 26 May 2015 18:26:33 +0000 Message-ID: References: <1432316725-21393-1-git-send-email-abbotti@mev.co.uk> In-Reply-To: <1432316725-21393-1-git-send-email-abbotti@mev.co.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [184.183.19.121] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 887 Lines: 18 O n Friday, May 22, 2015 10:45 AM, Ian Abbott wrote: > The Comedi "comedi_isadma.h" header is included by the source for the > "comedi_isadma" helper module and other modules that use it. It does > not compile cleanly when it is the first header file included. It uses > the `dma_addr_t` type, so include to declare it. (Also, > that indirectly takes care of the use of `NULL`.) It uses `struct > comedi_device *` in various function prototypes, so add an incomplete > declaration of `struct comedi_device`. > > Signed-off-by: Ian Abbott Reviewed-by: H Hartley Sweeten -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/