Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751529AbbEZScr (ORCPT ); Tue, 26 May 2015 14:32:47 -0400 Received: from p3plex2out01.prod.phx3.secureserver.net ([184.168.131.12]:33993 "EHLO p3plex2out01.prod.phx3.secureserver.netIMP" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751015AbbEZSco convert rfc822-to-8bit (ORCPT ); Tue, 26 May 2015 14:32:44 -0400 From: Hartley Sweeten To: Ian Abbott , "driverdev-devel@linuxdriverproject.org" CC: Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] staging: comedi: comedi_8254.h: make self-reliant Thread-Topic: [PATCH] staging: comedi: comedi_8254.h: make self-reliant Thread-Index: AQHQlLVQt4hxjRLRz0uD8RK1NqidJ52OmrDg Date: Tue, 26 May 2015 18:32:43 +0000 Message-ID: References: <1432315951-24731-1-git-send-email-abbotti@mev.co.uk> In-Reply-To: <1432315951-24731-1-git-send-email-abbotti@mev.co.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [184.183.19.121] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 967 Lines: 19 On Friday, May 22, 2015 10:33 AM, Ian Abbott wrote: > The Comedi "comedi_8254.h" header file is included by various Comedi > drivers with timer/counters based on the 8254 chip. The drivers do not > compile cleanly if this header file is included first. It uses pointers > to the `struct comedi_device`, `struct comedi_subdevice`, and `struct > comedi_insn` structures in various function prototypes, so declare those > as incomplete types. It use the `bool` type, so include > . It also uses the `__iomem` tag, but that seems to be > taken care of indirectly by including . > > Signed-off-by: Ian Abbott Reviewed-by: H Hartley Sweeten -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/