Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751587AbbEZSwH (ORCPT ); Tue, 26 May 2015 14:52:07 -0400 Received: from mail-qk0-f172.google.com ([209.85.220.172]:34245 "EHLO mail-qk0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751140AbbEZSwD (ORCPT ); Tue, 26 May 2015 14:52:03 -0400 Date: Tue, 26 May 2015 14:51:59 -0400 From: Tejun Heo To: Lai Jiangshan Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/7 V2] workqueue: reuse the current per-node pwq when its attrs unchanged Message-ID: <20150526185159.GL7099@htj.duckdns.org> References: <1431433955-3173-1-git-send-email-laijs@cn.fujitsu.com> <1431433955-3173-5-git-send-email-laijs@cn.fujitsu.com> <5562EFA5.2030706@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5562EFA5.2030706@cn.fujitsu.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 705 Lines: 21 Hello, Lai. On Mon, May 25, 2015 at 05:47:17PM +0800, Lai Jiangshan wrote: > The patch 4/5/6 does reduce cpu and temporary-memory usage sometimes. > But it is in slow path where small optimization is commonly unwelcome at. > > Do I need to refactor the patches? I'm in doubt for the necessary. I like avoiding creating identical pwqs at least. For the rest, I'm okay either way as long as code is not made more complex in the process. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/