Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751572AbbEZTYp (ORCPT ); Tue, 26 May 2015 15:24:45 -0400 Received: from mail-wg0-f49.google.com ([74.125.82.49]:34173 "EHLO mail-wg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750845AbbEZTYn (ORCPT ); Tue, 26 May 2015 15:24:43 -0400 Message-ID: <5564C878.70101@gmail.com> Date: Tue, 26 May 2015 21:24:40 +0200 From: Mateusz Kulikowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Dan Carpenter CC: gregkh@linuxfoundation.org, joe@perches.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 06/35] staging: rtl8192e: Replace memcmp() with ether_addr_equal_unaligned() References: <1432223628-1664-1-git-send-email-mateusz.kulikowski@gmail.com> <1432223628-1664-7-git-send-email-mateusz.kulikowski@gmail.com> <20150525140336.GC11588@mwanda> In-Reply-To: <20150525140336.GC11588@mwanda> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1293 Lines: 34 On 25.05.2015 16:03, Dan Carpenter wrote: > On Thu, May 21, 2015 at 05:53:19PM +0200, Mateusz Kulikowski wrote: >> Use dedicated macro to compare ethernet addresses in probe_rq_parse(). >> >> Signed-off-by: Mateusz Kulikowski >> --- >> drivers/staging/rtl8192e/rtllib_softmac.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c >> index 8689b16..65297a0 100644 >> --- a/drivers/staging/rtl8192e/rtllib_softmac.c >> +++ b/drivers/staging/rtl8192e/rtllib_softmac.c >> @@ -1853,7 +1853,8 @@ static short probe_rq_parse(struct rtllib_device *ieee, struct sk_buff *skb, >> return -1; /* corrupted */ >> >> bssid_match = >> - (memcmp(header->addr3, ieee->current_network.bssid, ETH_ALEN) != 0) && >> + (!ether_addr_equal_unaligned(header->addr3, >> + ieee->current_network.bssid)) && > > Isn't this aligned? Yes, this time it is - my bad sorry - I missed this one. Regards, Mateusz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/