Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751722AbbEZTjO (ORCPT ); Tue, 26 May 2015 15:39:14 -0400 Received: from mail-qk0-f175.google.com ([209.85.220.175]:36488 "EHLO mail-qk0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751140AbbEZTjL (ORCPT ); Tue, 26 May 2015 15:39:11 -0400 Date: Tue, 26 May 2015 15:39:07 -0400 From: Ido Yariv To: Eric Dumazet Cc: "David S. Miller" , Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy , Nandita Dukkipati , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ido Yariv Subject: Re: [PATCH] net: tcp: Fix a PTO timing granularity issue Message-ID: <20150526193907.GC13376@WorkStation.home> References: <1432650358-11470-1-git-send-email-ido@wizery.com> <1432657435.4060.267.camel@edumazet-glaptop2.roam.corp.google.com> <20150526170222.GA13376@WorkStation.home> <1432660420.4060.271.camel@edumazet-glaptop2.roam.corp.google.com> <20150526175540.GB13376@WorkStation.home> <1432664721.4060.294.camel@edumazet-glaptop2.roam.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432664721.4060.294.camel@edumazet-glaptop2.roam.corp.google.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1689 Lines: 43 Hi Eric, On Tue, May 26, 2015 at 11:25:21AM -0700, Eric Dumazet wrote: > On Tue, 2015-05-26 at 13:55 -0400, Ido Yariv wrote: > > > > > The platform this was tested on was an embedded platform with a wifi > > module (11n, 20MHZ). The other end was a computer running Windows, and > > the benchmarking software was IxChariot. > > The whole setup was running in a shielded box with minimal > > interferences. > > > > As it seems, the throughput was limited by the congestion window. > > Further analysis led to TLP - the fact that its timer was expiring > > prematurely impacted cwnd, which in turn prevented the wireless driver > > from having enough skbs to buffer and send. > > > > Increasing the size of the chunks being sent had a similar impact on > > throughput, presumably because the congestion window had enough time to > > increase. > > > > Changing the congestion window to Westwood from cubic/reno also had a > > similar impact on throughput. > > > > Have you tested what results you had by completely disabling TLP ? > > Maybe a timer of 10 to 20ms is too short anyway in your testbed. Yes, I have (by writing 2 to /proc/sys/net/ipv4/tcp_early_retrans), and it also had a similar effect. That was actually the first workaround for this issue, before the issue in TLP was traced. With 10ms to 20ms timers the throughput was just the same as disabling TLP altogether, so it seems it was just enough to handle. Cheers, Ido. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/