Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751923AbbEZTmR (ORCPT ); Tue, 26 May 2015 15:42:17 -0400 Received: from smtp3.stanford.edu ([171.67.219.83]:45603 "EHLO smtp.stanford.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751747AbbEZTmM (ORCPT ); Tue, 26 May 2015 15:42:12 -0400 Message-ID: <5564CC80.3080101@localhost> Date: Tue, 26 May 2015 12:41:52 -0700 From: Fernando Lopez-Lezcano User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Clark Williams , Steven Rostedt CC: nando@ccrma.Stanford.EDU, Sebastian Andrzej Siewior , linux-rt-users , LKML , Thomas Gleixner , John Kacur Subject: Re: [ANNOUNCE] 4.0.4-rt1 References: <20150519213923.GA26363@linutronix.de> <20150526083449.5357059b@sluggy> <20150526093832.558e2e46@gandalf.local.home> <20150526084802.2cfd055b@sluggy> <20150526111924.20836deb@gandalf.local.home> <20150526104343.51fad474@sluggy> In-Reply-To: <20150526104343.51fad474@sluggy> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-05-26_04:2015-05-26,2015-05-26,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=2 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1402240000 definitions=main-1505260252 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1953 Lines: 59 On 05/26/2015 08:43 AM, Clark Williams wrote: > On Tue, 26 May 2015 11:19:24 -0400 > Steven Rostedt wrote: > >> On Tue, 26 May 2015 08:48:02 -0500 >> Clark Williams wrote: >> >> >>> Change the WARN_ON to WARN_ON_NORT >> >> Do we have a WARN_ON_NORT? I see a WARN_ON_NONRT, but not a >> WARN_ON_NORT. Does this compile? >> >> -- Steve > > Sigh. Of course not. Reupdated patch (and yes this one compiles): Thanks! Seems to have fixed the problem (of course!) So far so good and nothing weird in the output of dmesg.... -- Fernando > From: Clark Williams > Date: Thu, 21 May 2015 12:51:53 -0500 > Subject: [PATCH] [rt] i915: bogus warning from i915 when running on PREEMPT_RT > > The i915 driver has a 'WARN_ON(!in_interrupt())' in the display > handler, which whines constanly on the RT kernel (since the interrupt > is actually handled in a threaded handler and not actual interrupt > context). > > Change the WARN_ON to WARN_ON_NORT > > Signed-off-by: Clark Williams > --- > drivers/gpu/drm/i915/intel_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index f75173c20f47..30b1d16caa0d 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -9745,7 +9745,7 @@ void intel_check_page_flip(struct drm_device *dev, int pipe) > struct drm_crtc *crtc = dev_priv->pipe_to_crtc_mapping[pipe]; > struct intel_crtc *intel_crtc = to_intel_crtc(crtc); > > - WARN_ON(!in_interrupt()); > + WARN_ON_NONRT(!in_interrupt()); > > if (crtc == NULL) > return; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/