Date: Tue, 26 May 2015 21:46:13 +0200
From: Oleg Nesterov <oleg@redhat.com>
To: Kirill Tkhai <ktkhai@odin.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
        Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>,
        Michal Hocko <mhocko@suse.cz>, Rik van Riel <riel@redhat.com>,
        Ionut Alexa <ionut.m.alexa@gmail.com>,
        Peter Hurley <peter@hurleysoftware.com>,
        Kirill Tkhai <tkhai@yandex.ru>
Subject: Re: [PATCH RFC 09/13] exit: Use for_each_thread() in do_wait()
Message-ID: <20150526194613.GC6978@redhat.com>
References: <20150525162722.5171.15901.stgit@pro> <1432575941.6866.42.camel@odin.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1432575941.6866.42.camel@odin.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1099
Lines: 38

On 05/25, Kirill Tkhai wrote:
>
> Refactoring, no functionality change.

Hmm. unless I missed something this change is wrong.

> --- a/kernel/exit.c
> +++ b/kernel/exit.c
> @@ -1538,8 +1538,7 @@ static long do_wait(struct wait_opts *wo)
>  
>  	set_current_state(TASK_INTERRUPTIBLE);
>  	read_lock(&tasklist_lock);
> -	tsk = current;
> -	do {
> +	for_each_thread(current, tsk) {
>  		retval = do_wait_thread(wo, tsk);
>  		if (retval)
>  			goto end;
> @@ -1550,7 +1549,7 @@ static long do_wait(struct wait_opts *wo)
>  
>  		if (wo->wo_flags & __WNOTHREAD)
>  			break;
> -	} while_each_thread(current, tsk);
> +	}

Please note the __WNOTHREAD check. This is the rare case when we
actually want while_each_thread() (although it should die anyway).

for_each_thread() always starts from ->group_leader, but we need
to start from "current" first.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/