Message-ID: <5564D7A7.6000403@redhat.com>
Date: Tue, 26 May 2015 16:29:27 -0400
From: Rik van Riel <riel@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Artem Bityutskiy <dedekind1@gmail.com>
CC: linux-kernel@vger.kernel.org, mgorman@suse.de, peterz@infradead.org,
        jhladky@redhat.com
Subject: Re: [PATCH] numa,sched: only consider less busy nodes as numa balancing
 destination
References: <1430908530.7444.145.camel@sauron.fi.intel.com> <20150506114128.0c846a37@cuia.bos.redhat.com>
In-Reply-To: <20150506114128.0c846a37@cuia.bos.redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1558
Lines: 37

On 05/06/2015 11:41 AM, Rik van Riel wrote:
> On Wed, 06 May 2015 13:35:30 +0300
> Artem Bityutskiy <dedekind1@gmail.com> wrote:
> 
>> we observe a tremendous regression between kernel version 3.16 and 3.17
>> (and up), and I've bisected it to this commit:
>>
>> a43455a sched/numa: Ensure task_numa_migrate() checks the preferred node
> 
> Artem, Jirka, does this patch fix (or at least improve) the issues you
> have been seeing?  Does it introduce any new regressions?
> 
> Peter, Mel, I think it may be time to stop waiting for the impedance
> mismatch between the load balancer and NUMA balancing to be resolved,
> and try to just avoid the issue in the NUMA balancing code...

Peter, I got some more test results in.  This patch can supercede
095bebf61a46 ("sched/numa: Do not move past the balance point if
unbalanced"), which can be reverted.

With this patch, a workload that has one (misplaced) thread running,
and nothing else on the system, is able to move to the node where
its memory is, which is something that 095bebf61a46 prevented.

It also fixes the single instance SpecJBB2005 spreading issue, which
benefited some (but not completely) from 095bebf61a46 in the past.

Peter, what would you like me to do to get this patch into your tree,
and 095bebf61a46 reverted? :)

-- 
All rights reversed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/