Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752257AbbEZUpH (ORCPT ); Tue, 26 May 2015 16:45:07 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:34676 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752200AbbEZUpF (ORCPT ); Tue, 26 May 2015 16:45:05 -0400 MIME-Version: 1.0 In-Reply-To: <1425296150-4722-6-git-send-email-rusty@rustcorp.com.au> References: <1425296150-4722-1-git-send-email-rusty@rustcorp.com.au> <1425296150-4722-6-git-send-email-rusty@rustcorp.com.au> Date: Tue, 26 May 2015 13:45:04 -0700 Message-ID: Subject: Re: [PATCH 06/16] ia64: fix up obsolete cpu function usage. From: Tony Luck To: Rusty Russell Cc: Linux Kernel Mailing List , Fenghua Yu , "linux-ia64@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2485 Lines: 56 On Mon, Mar 2, 2015 at 3:35 AM, Rusty Russell wrote: > Thanks to spatch, then a sweep for for_each_cpu_mask => for_each_cpu. > > Signed-off-by: Rusty Russell I'm seeing a bunch of warnings building the ia64 tree: arch/ia64/kernel/smpboot.c:437: warning: passing argument 2 of 'cpumask_set_cpu' discards qualifiers from pointer target type arch/ia64/kernel/smpboot.c:478: warning: passing argument 2 of 'cpumask_test_cpu' discards qualifiers from pointer target type arch/ia64/kernel/smpboot.c:484: warning: passing argument 2 of 'cpumask_test_cpu' discards qualifiers from pointer target type arch/ia64/kernel/smpboot.c:544: warning: passing argument 2 of 'cpumask_set_cpu' discards qualifiers from pointer target type arch/ia64/kernel/smpboot.c:568: warning: passing argument 2 of 'cpumask_set_cpu' discards qualifiers from pointer target type arch/ia64/kernel/smpboot.c:676: warning: passing argument 2 of 'cpumask_clear_cpu' discards qualifiers from pointer target type arch/ia64/kernel/smpboot.c:747: warning: passing argument 2 of 'cpumask_test_cpu' discards qualifiers from pointer target type which track back to these lines from this commit: $ git show 5d2068da8d339e4dff8f9b9a1246e6a79e2949d8 | grep cpu_callin_map - cpu_set(cpuid, cpu_callin_map); + cpumask_set_cpu(cpuid, &cpu_callin_map); - if (cpu_isset(cpu, cpu_callin_map)) + if (cpumask_test_cpu(cpu, &cpu_callin_map)) - if (!cpu_isset(cpu, cpu_callin_map)) { + if (!cpumask_test_cpu(cpu, &cpu_callin_map)) { - cpu_set(0, cpu_callin_map); + cpumask_set_cpu(0, &cpu_callin_map); - cpu_set(smp_processor_id(), cpu_callin_map); + cpumask_set_cpu(smp_processor_id(), &cpu_callin_map); - cpu_clear(cpu, cpu_callin_map); + cpumask_clear_cpu(cpu, &cpu_callin_map); - if (cpu_isset(cpu, cpu_callin_map)) + if (cpumask_test_cpu(cpu, &cpu_callin_map)) The problem being that cpu_callin_map is declared volatile, which matched the arg type in the declarations for cpu_set() and cpu_clear() ... but doesn't match the new fangled cpumask_set_cpu() etc. Now the new functions do go on to call set_bit() etc. ... which *do* expect a volatile second argument. Should cpumask_set_cpu() and friends specify a volatile argument??? -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/