Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751747AbbEZUtg (ORCPT ); Tue, 26 May 2015 16:49:36 -0400 Received: from vpnchicago.adeneo-embedded.us ([65.182.180.190]:52196 "EHLO mxadeneo.adeneo-embedded.us" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751217AbbEZUtf (ORCPT ); Tue, 26 May 2015 16:49:35 -0400 Date: Tue, 26 May 2015 13:49:32 -0700 From: Jean-Baptiste Theou To: Alexandre Belloni CC: Alessandro Zummo , , Subject: Re: [PATCH 2/2] rtc-isl1208: add device tree support Message-ID: <20150526134932.26c2b81560deb49d1e8efeed@adeneo-embedded.us> In-Reply-To: <20150526202032.GK3199@piout.net> References: <1432667550-24272-1-git-send-email-jtheou@adeneo-embedded.us> <1432667550-24272-2-git-send-email-jtheou@adeneo-embedded.us> <20150526202032.GK3199@piout.net> X-Mailer: Sylpheed 3.4.2 (GTK+ 2.24.28; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [172.16.20.136] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1896 Lines: 67 Hi, Indeed. Sorry for the noise. Best regards On Tue, 26 May 2015 22:20:32 +0200 Alexandre Belloni wrote: > Hi, > > On 26/05/2015 at 12:12:30 -0700, Jean-Baptiste Theou wrote : > > Add a basic device tree support for isl1208 driver > > > > Signed-off-by: Jean-Baptiste Theou > > --- > > drivers/rtc/rtc-isl1208.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c > > index c3c549d..b47a3f9 100644 > > --- a/drivers/rtc/rtc-isl1208.c > > +++ b/drivers/rtc/rtc-isl1208.c > > @@ -692,6 +692,14 @@ isl1208_remove(struct i2c_client *client) > > return 0; > > } > > > > +#ifdef CONFIG_OF > > +static const struct of_device_id isl1208_dt_match[] = { > > + { .compatible = "isil,isl1208" }, > > + { .compatible = "isil,isl1218" }, > > + { }, > > +}; > > +#endif > > + > > static const struct i2c_device_id isl1208_id[] = { > > { "isl1208", 0 }, > > { "isl1218", 0 }, > > @@ -702,6 +710,7 @@ MODULE_DEVICE_TABLE(i2c, isl1208_id); > > static struct i2c_driver isl1208_driver = { > > .driver = { > > .name = "rtc-isl1208", > > + .of_match_table = of_match_ptr(isl1208_dt_match), > > This patch is unnecessary as the i2c subsystem will already match > isil,isl1208 or isil,isl1218 with the i2c_device_id array. > > > }, > > .probe = isl1208_probe, > > .remove = isl1208_remove, > > -- > > 2.4.0 > > > > -- > Alexandre Belloni, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com -- Jean-Baptiste Theou -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/