Message-ID: <1432674255.2846.103.camel@perches.com>
Subject: Re: [PATCH v4 02/35] staging: rtl8192e: Declare ethernet addresses
 as __aligned(2)
From: Joe Perches <joe@perches.com>
To: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>, gregkh@linuxfoundation.org,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Date: Tue, 26 May 2015 14:04:15 -0700
In-Reply-To: <5564D6C6.9040400@gmail.com>
References: <1432223628-1664-1-git-send-email-mateusz.kulikowski@gmail.com>
	 <1432223628-1664-3-git-send-email-mateusz.kulikowski@gmail.com>
	 <20150525135319.GA11588@mwanda> <5564D6C6.9040400@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 909
Lines: 28

On Tue, 2015-05-26 at 22:25 +0200, Mateusz Kulikowski wrote:
> On 25.05.2015 15:53, Dan Carpenter wrote:
> >> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
[]
> >> +	static const u8 bMac_Tmp_Addr[ETH_ALEN] __aligned(2) = {
> >> +					0x00, 0xe0, 0x4c, 0x00, 0x00, 0x01
> >> +	};
> > 
> > What's up with the whacky indenting?
> 
> It was proposal from Joe; 

Not quite.  I suggested:

	static const u8 bMac_Tmp_Addr[ETH_ALEN] __aligned(2) = {
		0x00, 0xe0, 0x4c, 0x00, 0x00, 0x01
	};

> perhaps breaking 80-column line would be even better in that case 
> (for sure will be once I remove __aligned)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/