Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752014AbbEZVlm (ORCPT ); Tue, 26 May 2015 17:41:42 -0400 Received: from mail-bn1on0077.outbound.protection.outlook.com ([157.56.110.77]:12608 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751188AbbEZVlh (ORCPT ); Tue, 26 May 2015 17:41:37 -0400 Authentication-Results: spf=fail (sender IP is 66.35.236.227) smtp.mailfrom=opensource.altera.com; denx.de; dkim=none (message not signed) header.d=none; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=atull@opensource.altera.com; Date: Tue, 26 May 2015 16:37:55 -0500 From: atull X-X-Sender: atull@linuxheads99 To: Pavel Machek CC: Dinh Nguyen , Rob Herring , Arnd Bergmann , Steffen Trumtrar , Pawel Moll , Mark Rutland , Ian Campbell , "Kumar Gala" , , , Russell King , , Delicious Quinoq Subject: Re: [PATCH v4 2/2] ARM: socfpga: dts: add sdram controller dt binding doc In-Reply-To: <20150525123902.GE9943@amd> Message-ID: References: <1432317735-29413-1-git-send-email-atull@opensource.altera.com> <1432317735-29413-3-git-send-email-atull@opensource.altera.com> <20150525123902.GE9943@amd> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: DM2PR10CA0067.namprd10.prod.outlook.com (10.141.241.35) To CY1PR03MB1520.namprd03.prod.outlook.com (25.163.17.26) X-Microsoft-Exchange-Diagnostics-untrusted: 1;CY1PR03MB1520;2:vn1gDyo+tshifPcRy1fQGXFBD4DhL0MqCpEStp8slJhz2w5JCL2WSz3+roIDzOem;2:paKvCftLOpYyhSer9HFb80hodfhIBf//V0Emjw+36yb17njX3F5os23y6V/nA2DyNZ7ogrlGC71enojPo2PQYBLJOj5w6p0gjQfbO+b8aCAgPypiJLJK9axnao77FRpHX/Uijwveea3VWkkUJWSDLvM6eWPHnBPr6/qZUToGz0vp1huuM9DJYSanipAkkRar;6:1wyEXRFiAKTvmU+lI428I/vlcSXuA5uN7EpHP7d46b5i0k6FhR2zQTeudLDRtR5nXnm7NcbE9PxxTZi+SrGi0k8pfXh/2jBOziEgI+7yPq6ov9wufpmnLP81mZZsNApQPs91n/g5eL9jfaCDlm/PXA==;3:L16ML1TrTXf/1x2eTbIPm3IHLuzA+YtOWP6cal55IWkrYsUOJGz8z4fhAn3vuLOJv85qkWhhHWh/q/TrmjsXld0aCGJROucAXkUaPCeTyZuahwx4MipIzUkFr2yEmnY620b+niEUOc9HUVtyz3WLzciZvQuS8Ny4sqTQx9VRHFOZTHHhMdvFi7f2QReREAVe9y0dKFG1ezGKDEvb8wLYNihbGE+9x1xtITkg11vtL9Ap/EmYqxK0ns2b7aJ9+ZLlvr6CX+gH0nznpaNwTUJjoB/cTRgyAKopAgIWHqZjPUsrVTajcfs1oJOHpr18DMfM X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(42134001)(42139001);SRVR:CY1PR03MB1520;UriScan:;BCL:0;PCL:0;RULEID:(42134001)(42139001);SRVR:BLUPR03MB309; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:CY1PR03MB1520;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1520;BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:BLUPR03MB309;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB309; X-Forefront-PRVS: 0588B2BD96 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(6009001)(51704005)(189002)(377424004)(199003)(24454002)(42186005)(106356001)(46406003)(66066001)(101416001)(76176999)(54356999)(50986999)(69596002)(19580405001)(83506001)(19580395003)(86152002)(50466002)(23726002)(33716001)(46102003)(62966003)(77156002)(81156007)(4001540100001)(97736004)(4001350100001)(5001860100001)(47776003)(64706001)(53416004)(5001830100001)(86362001)(5001960100002)(122386002)(110136002)(2950100001)(15975445007)(77096005)(189998001)(68736005)(105586002)(92566002)(87976001)(40100003)(3556765001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR03MB1520;H:linuxheads99.altera.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:0;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?us-ascii?Q?1;CY1PR03MB1520;9:ejNC1y8OhsapNIaV+ORexhBssmu3bXKuwld5+RMkRJ?= =?us-ascii?Q?IuabPfHnYKCUQj4jmEwoEH2WzdfKDhkFqLLLUJ8hcP73dmU5HTcZRQN3yoHD?= =?us-ascii?Q?OMkDChf/bdDeRosrvmz1//KZ1rlCk3xA0vdcum63hN3O6qUBGmHsMIAhIlcK?= =?us-ascii?Q?2Qf9CEIB5x7YVFr1Brvi2vAMjZLVtW7/ZTDBBKiMxzQfdG++Fxq31OXtt2pz?= =?us-ascii?Q?J5dG3UmjfIALikPH8XcdAaubPGZooeoKWdtruSBwJhd5wwyzVKip/45h9qZ3?= =?us-ascii?Q?FG1K7WCoh+zBNoVjaEd6h5SvwCEQoFO6IjMtI80wPJcbI12ef1gHAWIoCgfZ?= =?us-ascii?Q?9i6MoZ+aGz1/gHTdcWvEO4UzV1LFDzIGNJOreXneD2cI7RaLyJaKUHikhctM?= =?us-ascii?Q?O5XE7rbbSuO50rz41hzBkNyw94IWKKitFEg4lwkKw6pqh1a7BRFLDUnzeaZB?= =?us-ascii?Q?WF9JHwR/2BzRtRuArUbBdu9tQRTpifZ+nkX+kTyorn66aKzk4qCahybH+q6N?= =?us-ascii?Q?XEj3KsZVrq+OoRC+lZSTJ+jNstSHGwGLXDlSMxWrB4qmvUxET/gSeNvgM9IL?= =?us-ascii?Q?i1V2YVb3M2rlNeMboWZkyoYP9v0sCP5FMRgEjya4JvaG4ZiVukYH0rBdCxnx?= =?us-ascii?Q?q1HDqaYHeWCADcY2YetzsHpVLVdHnyum/go8wHkxEvav6PPLaOd5+6DC6J+3?= =?us-ascii?Q?0LEdLqDSxmqE5BOQ03S4bT3yPfsUosaV6RjpE9my8+jiLLY3SzbSjezW5ClG?= =?us-ascii?Q?7UXKA46aDzHfYZ8MDDg7a6wRqow+/6YxYwl3Iw6bjs+SFCVNqbNiq+dIWDyB?= =?us-ascii?Q?UqZjdXrdcLYNfVcwV9SgfrxGRZmy94F13gBMjYDcM+mdtVKvcwEI/BiSnn3T?= =?us-ascii?Q?Q/PL5XP2Lfr3rw9rrQoPvbp8aYI1agORA7kHqtPgXI6Drv/umwPP2a6zmbEL?= =?us-ascii?Q?NuFuouuVVE1SG/C69kz6qybARc1H0YlFfRkRxglFDK3WDXuNj68F9VmCEYf8?= =?us-ascii?Q?dXCtweRaZDeiz3QaWdjTIZRQbV7pNM0GvS78YSSxlQ5CeTtlJEQtQ+NonVqM?= =?us-ascii?Q?TPo2PZrBpuqj4CkUWw8duUo+KK9D5AiZbz9Y3EclCW5m9kXIYTG7WuVshgQG?= =?us-ascii?Q?p2PiRfp6fX/lgA7cacfP2o5Y9msz4SOOqWa5URV76bFzSkHk+32XQnm3k3tj?= =?us-ascii?Q?EKR59WMpShp94OAyM2FmEVf8/Z3Vw7m1twa4qBsdjNLePywWNShDitJuiejq?= =?us-ascii?Q?j3snvE2W91AybH7BM=3D?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;CY1PR03MB1520;3:GH7n09ZFE3YjbNgu8ZYtb1zUTVjQ6FeCFq9WS8L45Uo2acZk0yZNC0CbVZlvjiV+BCilhqS3EuznuXYRlYoSzomTozjAQ/DtXdoLx71QjCcaeLXvhmfIYDuvpAWH2gBDskNBztMHgGH826nHlPQM7Q==;10:f/m3UeSNUL3qbHcjzOM2717rn4orohqpgmh2EQull+YiZZQzlhbybsmx9S37qD3CNGWpz/vhdphG59Z+Q+a13EK2jpQDy4g0rOQWWpsY+nk=;6:8VZMIYlqJs1S4I5PqV1xKMIIz1EeCeDRpbz3yJDhZlbMV8hY1YQlQdbkej+LemuhECFG4YXK1G55AjklgOQnY7ZZ8BwtyQPXplM2+XwH6REo/JTgYVPxgsFQ9UlNiwh2p2aGz0rq43LfzHD8NYUnvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1520 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BN1AFFO11FD049.protection.gbl X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD049;1:uAentTLf4bz9Vc9GrLgrAZs35cpPunu+WpjZDm4X79vbdvFftT/NJSrnoRm8cEYhKdLGQrvS23vzAKn+5C80keNnMfNeJambltAcAU4yiBGAlCIaN+OmiFM8ni0OlZF2rICDOaDrrVJ7JIc/v330zfA9j1HmH8OT77swNHGGBrGB693IJSixIKLuUuWQsSmrju+YpnJGyoGGXIraGzIG6KBl3+jhk4GOPh1/NwjmSil6Y9/iBYOvnTwidOb6wc8ENreguMVf87Hrpj2JQB3XMw== X-Forefront-Antispam-Report: CIP:66.35.236.227;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(339900001)(199003)(377424004)(51704005)(189002)(24454002)(106466001)(19580405001)(19580395003)(87936001)(64706001)(66066001)(86362001)(50466002)(86152002)(83506001)(46102003)(47776003)(16796002)(46406003)(33716001)(5001860100001)(77156002)(62966003)(110136002)(92566002)(5001960100002)(50986999)(68736005)(15975445007)(77096005)(54356999)(2950100001)(6806004)(53416004)(81156007)(189998001)(76176999)(4001350100001)(6070500001)(97736004)(4001540100001)(85426001)(122386002)(105606002)(5001830100001)(23726002)(40100003)(7099028)(3556765001);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR03MB309;H:sj-itexedge03.altera.priv.altera.com;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB309;2:So8qXR/cUbwHoBwldrrhI7Au3HjdruAIAp/lWjBtgjKGXf+GRL5rGHz7X0ky5V2n;2:9WjKpMhplfqPPpL8GpTgs4QfEMDGeTCGmGHU83UTysKSST36tOq3DHvR/xEgMvKJOhva2h2WZeVmsNy7cwWpEgcAwpB6qiUVG0f0WPBNSAK7fSO3bfmSatBfuNDZJmFzQG8V8Gq8+vkqxPn/IT2ZFQxvr8J3KhSuuC7tZDDLsSyuc3kHpgLItHl6uzo47NnrE9F7fS8kw7bHiDf3HMGnhafGRPMoYiuZfaYe7XRRlPV7sDtuDrs3KxDMdqX9KCauB2kosWpMDUIWwciJ9nxnKw==;6:abugYC1FWtAapqfsWYOds0/Bx0DO2MtVzypElhcKQgTG1JrbGg7W5JjwjbQK3amABMG8m+SHSvw9xnm51FeOzJyYGf/CUUFoabxcAi1mNAh2ge9tBUThj1syoow96sqMwkDTDoamP8iaGn4QEJ6dOw==;3:HwpBerhbVq0F1lwGefKJxUYO55o9fnOkB34wbWPp+NbwRh9iKpmIBZ+2IyiStKNvR2EbeLek9EoBOl5Kt7tfAc57jZ/4rCyv7ZYLFFft87npeCKMnJ1W6HZnVHA8WUQSMzqE1Xf5D+nv7e/q7Grk92sCnBsLFFzb76RikoUy8xAYH6koHxoFi50RHZkwVcIxtSPEvZ3N9ie4bpAeo9qP3DVqZg7jZm4olo9L/GRaChQ35pOdYrS5C9p4UEIxT5wyYuV+4f+ifInwq52wQ4K6e2Um67Eqc4K2JrpipLx/yh2Gea5MzIBf9ZVsxCnGFPFn X-Forefront-PRVS: 0588B2BD96 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BLUPR03MB309;9:H2Jop1iF/q6VEhAtu6etaSprmSHhTdflJp8gSG9eNWJ?= =?us-ascii?Q?hceAIKrHpDNnLO3sOPZrccb0iw0jTyJeDtxMUaRVMqWoC6Y0Bbbj1FlJyEQB?= =?us-ascii?Q?MIxWQsrbwcaxHFwr2Aq84BbOZ0ZN83dadMSnNsxRBJu+AXa9cbHssxKyI7oV?= =?us-ascii?Q?pCnYUzbgwZAy73cD+KDirHisGr/wi0aF9UEkfMl5+PFCRrMIz6FU2Fm4bV/6?= =?us-ascii?Q?5E+0XvLJ8gIb4PkbMfvMGddDspFGb0OPtXiEXTMMnz1GUp+yugxAEJn9ndZI?= =?us-ascii?Q?Nm5TuICHydP29W8W9tzExognOZT988t204DBlqwtC/5lE2BUfYZWe9E0yqbs?= =?us-ascii?Q?2Xi3AXe14Ee+91XhoBkPtoYE/EZjghaFs0lzYSl7XdN5TpKRxsoSKFhIRP/m?= =?us-ascii?Q?L8J9CMPqs3yDHRElWLoNOZ2uxupDoX1SorO4zCrzUgK9xTxVnFAF7z9n7Nf/?= =?us-ascii?Q?cQn5hU4gMZlPg+CYHwXScztBYfGspbnu8ZeZYKfrcVEJhhubvA6gGsQsKt6N?= =?us-ascii?Q?UqPtDKH849qdtxgTCzCbLkF0sB/Vyl4/mRsfjtBySMuAUIudH3ZZs7LfOQpv?= =?us-ascii?Q?YJF0SEmw+nMCFQNrPLpjOfpwDHfjFem9YlfCAagQ39Qkvxm51K9P661s8N6O?= =?us-ascii?Q?ndTMrwzAMToJgBxrMGFT21wflY95CU4MTWQnSa1eE21WtgSBBdsnCtgiuhJO?= =?us-ascii?Q?sUul/56/JHEPv1OdOpdVLsotYimIbi/sJ30G6nYIcHAvgBngWojFFpamAWnc?= =?us-ascii?Q?kZvm/ZzCX0dX9JCE8GAu486n5PlAHu9rmCKzs7VdzvMeObtqkLLjoHs0hew4?= =?us-ascii?Q?pTgpGGrpsAWn9O9VECz+BKtIsWB8coUrUyDSN1EaqtpVK8ap/LiyzH6u8VSm?= =?us-ascii?Q?VnqkQ2voFZs5xzO3txvZdDpdle/ukeJ+LkDXRhdNFUdtesnEUIqB6tsudYE5?= =?us-ascii?Q?pkX/DmZZ/OkMYNO2jY7aezO1ndHLzj2f6EkzWjAl+tXXf2pt2NYrDUk+lkeR?= =?us-ascii?Q?DWhJHNVJ7tcCLQ717OWSHM1qTmzFvL5+9Ob8YhqvkJw6yTK4ULvvK5xKuILS?= =?us-ascii?Q?SB8IQnX1v79FvvV3VM4bDFAylkr8S5fiHh8xkQSmtr1MeAa96eELc4qtB3/J?= =?us-ascii?Q?5RdSkycLzR2fNTG2GXi3qLL6RjAEhBhkMvtJ6XiZs2xaQp8cedq8YzVAtvGm?= =?us-ascii?Q?gFY/f8BM9XIwaZwjIzqbzk9S3oJjMUSIPjd/lQtv9e/NbA/q+MVk2PCvaWo8?= =?us-ascii?Q?v/1hOr/BF9bzcpDMhMZxdV1UP53x9vhWOXAKlEIOf9pTkuC5crD7ZCH/bsyr?= =?us-ascii?Q?08Hr0lD2kRdZUJzx42TU=3D?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB309;3:ZeqN4+d+LZ+NuMQIYKkxyLGZPbSDBBYCA8UBom7Quae5D9FbHO6x92APym8m1euiR52CLuBgK2IRSTbjJm//fCjSqavGemQiktnhvLeMiQCLG1tVUweUPGVuJJu3RKHhLjGVwJUNiRZ6bLq4cXX9qg==;10:BBfk6VP/f5J6mLdY3ZZrIeQ2JHfC2HMEo157iH/1wrUuk3HDfPN+cQom0BWYeVNF1AzF07iUXJ2z0kPDh1GGLXImkZKLiv7N8JLfvTz3MZc=;6:y4n3fEKTNRxU4VsrWPaNX6K+kraaQ/D7xj/MwVcpG1JLubLaIhpa1DEg5/s0NGD2fc0EFirLkYPWirftv+ZB1BkfJrH7Is5+39yEU37Mln7b7HpUJEHl4w2C5kP+JX4SgWgyMuL4LCuqvDEe/VSeYw== X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2015 21:41:33.5339 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB309 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2536 Lines: 64 On Mon, 25 May 2015, Pavel Machek wrote: > On Fri 2015-05-22 13:02:15, Alan Tull wrote: > > Add binding doc for Altera SOCFPGA SDRAM controller. > > > > Signed-off-by: Alan Tull > > --- > > v4: Add bindings doc > > --- > > .../arm/altera/socfpga-sdram-controller.txt | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/arm/altera/socfpga-sdram-controller.txt > > > > diff --git a/Documentation/devicetree/bindings/arm/altera/socfpga-sdram-controller.txt b/Documentation/devicetree/bindings/arm/altera/socfpga-sdram-controller.txt > > new file mode 100644 > > index 0000000..77ca635 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/arm/altera/socfpga-sdram-controller.txt > > @@ -0,0 +1,12 @@ > > +Altera SOCFPGA SDRAM Controller > > + > > +Required properties: > > +- compatible : Should contain "altr,sdr-ctl" and "syscon". > > + syscon is required by the Altera SOCFPGA SDRAM EDAC. > > +- reg : Should contain 1 register range (address and length) > > + > > +Example: > > + sdr: sdr@ffc25000 { > > + compatible = "altr,sdr-ctl", "syscon"; > > Is the syscon binding good idea? Should the EDAC driver be fixed to > accept altr,sdr-ctl binding, instead? > Pavel What problems do you see here? I'd like to avoid changing the EDAC if possible. We have 3 things (EDAC, fpga bridges, suspend) that need access to the sdc. They access 3 nonoverlapping sets of registers within the sdc to get at 3 different sets of functionality. Both EDAC and the fpga bridge are using syscon. The suspend code can't use syscon because it has to be assembly running in OCRAM to enable self-refresh for the DDR. Thor Thayer ended up using syscon for the EDAC after a thorough discussion on lkml and several revisions of the EDAC driver that tried it several different ways before finally ending up back where he started. Alan Tull > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/