Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752322AbbEZVoY (ORCPT ); Tue, 26 May 2015 17:44:24 -0400 Received: from mail-by2on0057.outbound.protection.outlook.com ([207.46.100.57]:35619 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752282AbbEZVoR (ORCPT ); Tue, 26 May 2015 17:44:17 -0400 Authentication-Results: spf=fail (sender IP is 66.35.236.236) smtp.mailfrom=opensource.altera.com; denx.de; dkim=none (message not signed) header.d=none; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=atull@opensource.altera.com; Date: Tue, 26 May 2015 16:40:35 -0500 From: atull X-X-Sender: atull@linuxheads99 To: Pavel Machek CC: Dinh Nguyen , Rob Herring , Arnd Bergmann , Steffen Trumtrar , Pawel Moll , Mark Rutland , Ian Campbell , "Kumar Gala" , , , Russell King , , Delicious Quinoq Subject: Re: [PATCH v4 1/2] ARM: socfpga: support suspend to ram In-Reply-To: <20150525124133.GF9943@amd> Message-ID: References: <1432317735-29413-1-git-send-email-atull@opensource.altera.com> <1432317735-29413-2-git-send-email-atull@opensource.altera.com> <20150525124133.GF9943@amd> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: SN1PR15CA0021.namprd15.prod.outlook.com (25.163.200.31) To BN3PR03MB1512.namprd03.prod.outlook.com (25.163.35.150) X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1512;2:aMQhGYLSpKvEP7GKnA6RkhkT95SJ803jrBqPSMETA9hRB8DShM6EOVdyKDeAc4l8;2:SrgyefYtyfD2mrq0j1eBtJehj9LD5gTZogrohdOpMhlOCFhR9RpOl+ukPsM8UACQ8mlxBxybraJSHWf62EK++i8uKrx2OfxPrCGjRRpDVkdpq+V/KTqZrLc+GBViSHU1pjWj1VyAnEUV9WvCxKgGxA==;6:ALN10tv1v3bQlBay2/NblaiF2iOcW9nJckx7wumfLI3CVkWdll1HghMacSy68VqN2v1TjjPTh21KXTb68SxAzJ/92eVkwP0st6TxOQTehlgiR/TgR6M5FjTOI8qOKsxm1GDjcEjKuKWQ50Foi1Cweg==;3:MHGnX3tAITsH6p9gKztsbRAb6YIs0p5IQRwlff9QkV5h8YrrFjL6VEhxqh6W55YRoXMBzr5vAOcDBLVC7P3T2tJB65JuPCO97XIymOujp83XSMsRkLaCnfu5NXoPIAT/Df55UX0D4vo5+8sNpU+XpWhBM66t00mTr2X6cTBDIiDTNHysD8wHAMVJVwlIxzEiifJD7k5LqPypZDMaad9qPdSajmMql7Y0/MI7PCKYxdWlbSTwZZyGBonqiXpU3JTGC6nzVX9rDyunoBKO3v0L6yAM2cUtzxE/ScOOSFuSEyOtlhYv/gpF6QCXAr1tn4lS X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1512;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR03MB041; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:BN3PR03MB1512;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1512;BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:BY2PR03MB041;BCL:0;PCL:0;RULEID:;SRVR:BY2PR03MB041; X-Forefront-PRVS: 0588B2BD96 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(6009001)(199003)(189002)(164054003)(51704005)(24454002)(51914003)(69596002)(81156007)(47776003)(53416004)(5001960100002)(2950100001)(97736004)(106356001)(68736005)(54356999)(110136002)(5001860100001)(50466002)(46406003)(42186005)(101416001)(86152002)(5001830100001)(77156002)(62966003)(64706001)(83506001)(122386002)(23726002)(46102003)(33716001)(4001540100001)(77096005)(66066001)(50986999)(76176999)(92566002)(40100003)(87976001)(4001350100001)(86362001)(105586002)(189998001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR03MB1512;H:linuxheads99.altera.com;FPR:;SPF:None;PTR:InfoNoRecords;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?us-ascii?Q?1;BN3PR03MB1512;9:OXlShAVm0yfLrJx+2DXm3cb4g+BGjyKVfhVaFiedeY?= =?us-ascii?Q?XftCdFoIf81t3OAolf0ciDl2sGsXmmwuCutE+S0XOaRzVe096zNS71Qjo+1N?= =?us-ascii?Q?n/E/LX+vwIMRnh+Yo7Tf8yX0N4+dy17IQ19cPPQEIWyRjuko5KW2rZVbTwWW?= =?us-ascii?Q?LcsvMye8lE+YY0y8qaU1dRTqiyncWVDM5HfjCG8nKkllk5cFzBBl0zGSrrJW?= =?us-ascii?Q?bW+blr+OVuGjcTgKbCJ6sMgGcrMMvfCDf+gDk8De97cgJqvi9fWrfY1pMFK0?= =?us-ascii?Q?01q/JtITHYdfJSVqGFjOW4+5mn/Q8XkTFDaLUVk4Bxx7Spow+z4kcAz8x3fb?= =?us-ascii?Q?1Nj5VPp4B1CGD0VoilI/K+a1+gJ1VlH57Ljhi+xAO7GpOH6kuOkRTWzFPg0w?= =?us-ascii?Q?KSQkhbJwqpcxgNttb1zG8o3zgfAK83HSU+Yx+D2ImPbaP3nkWEwYGC3/PNuE?= =?us-ascii?Q?JW3pHtZoteCRLeENxBEld/o/xR8y6E6cStWYDMSTzzkzgV/lh6+NVQ/9ZgOw?= =?us-ascii?Q?Fwf2BgPziAl4IkxLDzREhTYD7KCUqZTXgH2m4hpR/04keQGmgRY+IF7EeTuu?= =?us-ascii?Q?KjPfCAr9t19C4ce30ScZLS7Jhbv36EF7Np+dvtJj2ftZ0Fy2mM8Mmm21e5Hn?= =?us-ascii?Q?PzIsdchXHFYpOxKo4g+mY7YNjx/Vfc2QB2TJ+PWQqEYo7BJIAC7Gh6Zskqmd?= =?us-ascii?Q?CkXvQD6r27UWwyYXF6qPBLmqUhuIvgBTktmJgpVZeUQyIYXDoG+03sOhWIxH?= =?us-ascii?Q?Nnpm1Jsp31WjbyMIzZiY0JNftgEG9evIrCD+shmsKb+1M3aCXloJA1CLJ4r8?= =?us-ascii?Q?Ur2N1d2kBn3oR274R3AWtSBwD6hBEf4M5rRASiWLn1Ora3wYg10aC70RmgLg?= =?us-ascii?Q?OiZNftNqo2ceBnk4K36mO/E3Kj8+4NGO0r992A6ikA0Dv44ADUWKz7fDDL6K?= =?us-ascii?Q?0/sOQacuTYxvbXp8/Ca9bmqyMikZ9m0Qf1aR0W+qEGbEBosmDgr9iEbiDDcQ?= =?us-ascii?Q?CjjuWEC1QBE9ZypacjlOhQaCY0r/LGU9xMyNd0Xg9wGL2k7h4UGhOKHju2vo?= =?us-ascii?Q?24xeIWOAlZjTWc5fbaPszZ+44iRKsOTPKi8acsigykdB0HNzghjkuv0+hux+?= =?us-ascii?Q?lHhOPPYgrp1nYxHpep929F1yfLUFtn67xrWfc1zOYiQGQJOG8StQ=3D=3D?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1512;3:yM64iJc++/Go9R3eq1ZbAcpe5ZRRCR/bf8/vlWWXF+eL9Of/H31FtuQVOUCsuaEMZYn/aWleVLzAD19RYmtvscYb1epW3qzse3l6i4g29LKry52xDL98VAlNjKlAv0GjBM+rZNE3UmlA3HD8xWVl2Q==;10:yhomMLCvCkpOCUwXoXUuEUXAf4gSGTl6wVN5xiFegwBAfeEgklXZzDK5PqdIrIDv6swhWxYPv9E/lhQLdOkpF5pGhyhKOI1NKBaUalNDUjE=;6:VIaaZ8Wa3sNqpPw2Sdjymg/cJcMfqUgRhLZfSiQ5d+9LL06GefIuJzmrYu9YGB9iSaoFFgzGxV3PzLA0aKF/KXegfNHQQ4GlO7rnDfnJkO7HZtARnfcke0ycO7lQ1KHP29HUoxi9f4uK39lisAS3Sw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1512 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BN1AFFO11FD050.protection.gbl X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD050;1:8eE8QSfDYbdZFvK0unY4qIxijYi+lOJeXy1KUkMAdaqDEkYZQF4GN8iKItck+P2UQlnTmioP5pWyhncbTJ+9cJYrwaF8NX6w9ugCas6zNU+45prg3xM8gnc36tMU6aVSLtJ/2kai6yrhpZ1tatPlIWdbdVaUPr5UbPAus3g+4+qRpIEOYVjiJwT/dlEVvv7zicSqHAHybymPxYPINB7fOcMjWqLjBUr4j6Nhr3OJZ6jyFzqOC1XZjeK5heDZF8dboEpKE1HLEdyJs78Rl0W/lg== X-Forefront-Antispam-Report: CIP:66.35.236.236;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(339900001)(189002)(51704005)(51914003)(24454002)(164054003)(199003)(77156002)(81156007)(62966003)(4001350100001)(2950100001)(64706001)(47776003)(77096005)(76176999)(54356999)(92566002)(50986999)(68736005)(106466001)(105606002)(97736004)(53416004)(46406003)(4001540100001)(33716001)(50466002)(5001860100001)(5001830100001)(110136002)(189998001)(40100003)(6806004)(6070500001)(86362001)(5001960100002)(122386002)(23726002)(16796002)(66066001)(87936001)(46102003)(86152002)(83506001)(85426001)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR03MB041;H:sj-itexedge04.altera.priv.altera.com;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;MX:1;A:0;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB041;2:Tk6D2ezDolK64Nn7s6Cqpb+XolnI1yejV+fzIqq7n6QczV4dzFlq/yk8Uh93TZdk;2:hArl0ukNYfJBLLNkgwD6iK1I5U+miCFYWRmvUJ6p37Ly2U9sq+trdcfTHSH/m+8EjlglsN8pHrRdcZy32mNLPbZ5PwyNRbg88XVVFQCH7oSQ1pdoDU8TE4YRLvgtUnnXznrMCyWaz1mp0MeI4VhRao/IF0nniJfGiIbYuA71zPi02IE7NgXXMp+MPVX4Ol2BYEug1o7Rs7aEPSATOd8gUN85hzsnaVBEjo4whSlycME=;6:Rr0pkcvxLO66HK+KtGfTrILwgYxCCWuX6tHrgd9CCJ8/tRWS0HxvKtNTMsgjcma8OAA9IhmImA8uGX8hAfTb6orlKJVeCsWx7TOlYyhwHcB6U40hyXPDeQCZo7AzSO+EwVQydTaGxCzOLVkHSpRggg==;3:iQGGCY1xIVd+1NpA04wnkvwPdOYm88xAQT6ADT8MVCewBkDJyBP5+f/pizIlypKFVokA3NQKx9Ilbb/H5NTZIJtRbW06zXQjBaJ3I4Qn8NPClyDbynZbnXF3T3YDu2EMWiUlVuD/3+8HJ41SkEQWdC7aGvez0J08gvnX0ePA1FyFV0fPh1/03/71X+WRqkwLImA1NUiISwowgUdAEvqaDQeFFvquTe5hiAO/NWla25u8KYsACijD4pxLbTWmCwmHuIynXNJsJS9n7K5IXh1ZOeAfGUYYoa+k3v9A40GJcwqYdhiHyEJz4txkZbolHGq0 X-Forefront-PRVS: 0588B2BD96 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY2PR03MB041;9:16X0DB+Yh0BQ2x2npADPlQ8Tfax8Ii2vzimru1WLys2?= =?us-ascii?Q?akUA+/9RsSF4jSHbecIKeDsR7eaOJC4xeegt/ncEhx1vC05HZD5uM7so8UI1?= =?us-ascii?Q?LQT3wGU7nRhgrQ6/jyoTrHWGhXXfDN2UZVQpjbVxLsmT4421XsddBkT8OVbL?= =?us-ascii?Q?OxDjPjNftqhUA7FtwOAgAOBfVxnAyfaH64bm4mwp9kODvFpU04RvjEfboZFV?= =?us-ascii?Q?AOtsQDGwMYL+alyW7+WVHBH1UHbIRsf0VBEipb1aNbRZgr6iu2k+PZAfG8y5?= =?us-ascii?Q?TMhRPu1A5UnQMjGFwAh4AAj72uEJkePwaX08tFpUeBucvQEoqTEjyMuorvB4?= =?us-ascii?Q?vKNvJ+5YXk4NTZwDWtyxOH9DvilD8wQRT2mX0l7YekXyFRutsTuYPTgA9ROh?= =?us-ascii?Q?Qu3c7wjSGVqpvHRcpQNcgBv20p9iAi841joh2sjd4FSmaWhU5EWYPugrxROG?= =?us-ascii?Q?cOp8dFV9lZS1turBuU8cx/SWPIO9qdRKzv4UlX6mJE20Tuj/haEhUlf+r125?= =?us-ascii?Q?oNcI3w1SxdYT6yLIlh37jDDdjDqxim57PjnS2dRBBR9iRZiixkOMoKVcKb6a?= =?us-ascii?Q?53hmEO4Pdzh1aPrEWvSNragQaF+SL1RGVQbdXxAYbeD6NCIanLpjR0TDOwKb?= =?us-ascii?Q?I5KrdPMm5WMja1UOtxZpKmlkPJPhw4dGXbt1T01lJM5QESQfVbT5XKc65IhC?= =?us-ascii?Q?/8CJV7Qr9/nxXNbYvWHyf/3qZo22DBKCNLRvsn0zwFgv+m92AC7AO9ojM3ud?= =?us-ascii?Q?M4WXuk2KmTUsH9gLDwHKpnIQRKm9LBuwNGBDTMenWp7g1U87DLBXO6iIn+DS?= =?us-ascii?Q?bXCsfaCRSoh47OPHWijOMlcCxdkErJfJuemC8Upcuu6g59xhy3adnIc1Qezz?= =?us-ascii?Q?16NOvi53kR+1aoOWSOfGycD2MQzJqhmA/tlCDyyldbNujxmN7qW7Mf59zDsx?= =?us-ascii?Q?ueXMmcZ1z8kX/nV4GrCDyNm0gOi4/hTrJuUtheOg5aL6yZDZM6Qrz3srnd8t?= =?us-ascii?Q?pq7KFdoPtRSabT531Ojk6IrwwTmLN+8aJsvf5mkEScOd/5JbAtnqT5E/wGp9?= =?us-ascii?Q?8q6FNm40bcToqDf+fGJpJxuj7rrGhAVUs8g7mFcCimvZ+g38/czrlnWObWOq?= =?us-ascii?Q?caE4Yyf5SwCTlfaO5IP05LRccXkgu4aV5rQLOEvJaM6WwtBn0pAduifIy2vH?= =?us-ascii?Q?lG9knijhBKfDMdyox2SfqQVDAyrmtCMNp7RM0VbpgYH54hGdetkdKbQ=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB041;3:bSyerMCz3m4vdJjkY7T1am2JIH+Tm3EugPJVjABZnp4LgZcn6EIch0AtwuA43q+gkFc0Df4J2RmfGLB3bcAKt8TUvIJqfl8dmdcldExAukVn9mjOtiynQ5DtK/y8XQkmE1XiLejI6KcGBZxS5mjwIg==;10:Fry4pysdzSfiLga3jygk/9J4hxujUNPVIARldHbmoYffhpTBRT9c9WmLpR7NcAb2Go6/zdYwYdcanwc/PhONzuv4toeZ/ZTPSWBOfPKvrM8=;6:nl0nu8hoe7A3TalZa3ziHRvvo0e2s3fD+IKJoyaku/YMAyDpYtGXh+cgIi98YeoTOWtSv5HbniL0a8AtRRp6oQr/9HSTOU7vAqbrqla0YSXDAaBKCmswzo0JXpxlK345lDBekZRwCpalD314lxFbBw== X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2015 21:44:09.8461 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.236];Helo=[sj-itexedge04.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR03MB041 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1835 Lines: 60 On Mon, 25 May 2015, Pavel Machek wrote: > Hi! > > > Suspend-to-RAM and EDAC support are mutually exclusive on SOCFPGA > > platforms. CONFIG_SOCFPGA_SUSPEND enables suspend-to-RAM and > > prevents selecting CONFIG_EDAC_ALTERA_MC. > > Do we went to have the dependency at the .config time? We would like > to do generic kernels booting on many machines, this kind of breaks > that... > Hi Pavel, Thanks for the feedback. Yes I agree. One possibility is that I could add a suspend function to EDAC that always fails with a helpful message like "Suspend with EDAC not supported." If someone wants to suspend, they'll have to take the EDAC out of the device tree so its probe will bomb out. I'm not sure how normal it is to have suspend functions in the kernel that always fail, though. > > + /* > > + * This code assumes that the bootloader has already > > + * properly configured the sdram controller: > > Which bootloaders can do that? Whatever bootloader is configuring the sdram controller for the board. > > > + * sdr.ctrlcfg.lowpwreq.selfrfshmask = 3 > > + * sdr.ctrlcfg.lowpwrtiming.clkdisablecycles = 8 > > + * sdr.ctrlcfg.dramtiming4.selfrfshexit = 512 > > Would it make sense to configure it in Linux? > > Thanks, > Pavel The bootloader is responsible for configuring the sdram controller with parameters appropriate for whatever vendor's DDR is on the board, so that's where this must go. Now I realize I should make this message more general, since it is true for the socfpga cyclone5 devkit, but may need to be adjusted for other boards. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/