Message-ID: <5564FACE.9070204@oracle.com>
Date: Tue, 26 May 2015 15:59:26 -0700
From: Mike Kravetz <mike.kravetz@oracle.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Davidlohr Bueso <dave@stgolabs.net>
CC: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
        David Rientjes <rientjes@google.com>,
        Luiz Capitulino <lcapitulino@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2 1/2] mm/hugetlb: compute/return the number of regions
 added by region_add()
References: <1432353304-12767-1-git-send-email-mike.kravetz@oracle.com>	 <1432353304-12767-2-git-send-email-mike.kravetz@oracle.com> <1432585785.2185.59.camel@stgolabs.net>
In-Reply-To: <1432585785.2185.59.camel@stgolabs.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 852
Lines: 25

On 05/25/2015 01:29 PM, Davidlohr Bueso wrote:
> On Fri, 2015-05-22 at 20:55 -0700, Mike Kravetz wrote:
>> +/*
>> + * Add the huge page range represented by indicies f (from)
>> + * and t (to) to the reserve map.  Existing regions will be
>
> How about simply renaming those parameters to from and to across the
> entire hugetlb code.
>
> Thanks,
> Davidlohr

After adding the notation suggested by Naoya Horiguchi and cleaning
up that specific comment, I think using f and t is OK.  See the
documentation only patch:

[PATCH] mm/hugetlb: document the reserve map/region tracking routines

-- 
Mike Kravetz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/