Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758696AbbFAEqX (ORCPT ); Mon, 1 Jun 2015 00:46:23 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:45395 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750936AbbFAEqO (ORCPT ); Mon, 1 Jun 2015 00:46:14 -0400 Date: Sun, 31 May 2015 21:46:13 -0700 (PDT) Message-Id: <20150531.214613.1488046829950588850.davem@davemloft.net> nTo: vthakkar1994@gmail.com Cc: jeffrey.t.kirsher@intel.com, jesse.brandeburg@intel.com, shannon.nelson@intel.com, carolyn.wyborny@intel.com, donald.c.skidmore@intel.com, matthew.vick@intel.com, john.ronciak@intel.com, mitch.a.williams@intel.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, julia.lawall@lip6.fr Subject: Re: [PATCH] ethernet/intel: Use setup_timer From: David Miller In-Reply-To: <20150601044349.GA4730@vaishali-Ideapad-Z570> References: <20150601044349.GA4730@vaishali-Ideapad-Z570> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 31 May 2015 21:46:14 -0700 (PDT) To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 835 Lines: 31 From: Vaishali Thakkar Date: Mon, 1 Jun 2015 10:13:49 +0530 > Use the timer API function setup_timer instead of structure field > assignments to initialize a timer. > > A simplified version of the Coccinelle semantic patch that performs > this transformation is as follows: > > @change@ > expression e1, e2, e3, e4, a, b; > @@ > > -init_timer(&e1); > +setup_timer(&e1, a, b); > > ... when != a = e2 > when != b = e3 > > -e1.function = a; > ... when != b = e4 > -e1.data = b; > > Signed-off-by: Vaishali Thakkar Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/