From: Badola Nikhil <nikhil.badola@freescale.com>
To: Greg KH <gregkh@linuxfoundation.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stern@rowland.harvard.edu" <stern@rowland.harvard.edu>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        Joe Perches <joe@perches.com>
Subject: RE: [PATCH 3/5] drivers:usb:fsl: Replace macros with enumerated type
Thread-Topic: [PATCH 3/5] drivers:usb:fsl: Replace macros with enumerated type
Thread-Index: AQHQl6YjOcmv9iJfwkW31DPNv7r3cZ2VrOSAgAAFygCAAOgUgIAAhnsg
Date: Mon, 1 Jun 2015 06:19:47 +0000
Message-ID: <SN1PR0301MB16296A7CB8EF4F96DDC623F4F3B60@SN1PR0301MB1629.namprd03.prod.outlook.com>
References: <1432640748-18657-1-git-send-email-nikhil.badola@freescale.com>
 <20150531065035.GB17795@kroah.com> <1433056278.2984.16.camel@perches.com>
 <20150531210157.GA4007@kroah.com>
In-Reply-To: <20150531210157.GA4007@kroah.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jun 2015 06:19:47.0490
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0301MB1629
X-Microsoft-Exchange-Diagnostics: 1;SN1PR0301MB1567;2:iReL8irJGpNLDHrV6gHs4iCWwN65UiqSFiZ4ZcCmwlcCZTOJXyiBM0vQTmxBQP8J;2:oUOBxjOBYhhvC1FLW9JgbKSmy4Is5TYTg8KKOb3M9hvB2Pqf3M/K6WVBSxhlPlBOjaPnnx4TGNi+V9IAeoBlhyBeVETPAxP/PrJ5rj1i2Yt5fZ/pAHJ6J0RRJcwicLVNnXhiOUUlKXu4uP9HQ5GhoQ==;9:qQ+WTXkyO0krLStnwWOadaylULJ1uG2SzwWSQndHVLKIhrN/8K1BBdDiJxS/ijPXj4svJ8rZ1ejIP2Y5ih5SAYz5zbRIZytMgsc3POabjAeaNB6+LAxQs9H+5xbI0+bInmnKvqrV7rs3E4u6xBpQpg==
X-OriginatorOrg: freescale.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2636
Lines: 65

> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Monday, June 01, 2015 2:32 AM
> To: Joe Perches
> Cc: Badola Nikhil-B46172; linux-kernel@vger.kernel.org;
> stern@rowland.harvard.edu; linux-usb@vger.kernel.org
> Subject: Re: [PATCH 3/5] drivers:usb:fsl: Replace macros with enumerated
> type
> 
> On Sun, May 31, 2015 at 12:11:18AM -0700, Joe Perches wrote:
> > On Sun, 2015-05-31 at 15:50 +0900, Greg KH wrote:
> > > On Tue, May 26, 2015 at 05:15:48PM +0530, Nikhil Badola wrote:
> > > > Replace macros with enumerated type to represent usb ip controller
> > > > version
> > > >
> > > > Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com>
> > > > ---
> > > >  include/linux/fsl_devices.h | 13 ++++++++-----
> > > >  1 file changed, 8 insertions(+), 5 deletions(-)
> > > >
> > > > diff --git a/include/linux/fsl_devices.h
> > > > b/include/linux/fsl_devices.h
> > []
> > > > +enum fsl_usb2_controller_ver {
> > > > +	FSL_USB_VER_OLD = 0,
> > > > +	FSL_USB_VER_1_6,
> > > > +	FSL_USB_VER_2_2,
> > > > +	FSL_USB_VER_2_4,
> > > > +	FSL_USB_VER_2_5,
> > > > +};
> > >
> > > Don't you want to change that function that uses these to return the
> > > enumerated type and not an integer?
> > >

I missed that. I will do this change in the next patch version.

> > > Also, I don't think the C standard forces the non-numbered values to
> > > be sequential,
> >
> > Then you haven't read the standard in awhile and you likely forgot.
> >
> > 6.7.2.2
> > If the first enumerator has no =, the value of its enumeration
> > constant is 0. Each subsequent enumerator with no = defines its
> > enumeration constant as the value of the constant expression obtained
> > by adding 1 to the value of the previous enumeration constant.
> 
> Ah, you are right, I did forget.
> 
> But if you are wanting to use the "numerical" value of these, please be
> explicit when defining it.  Otherwise someone might think it was just fine to
> put a new entry in the middle of the list.
> 
We are only relying on the controller version to be less (or greater) than a specific version
and we are not using exact "numerical" value. Refer drivers/usb/host/ehci-fsl.c .
In addition, the enum entries defined are specific to controller version i.e 1.6, 2.2, 2.4 and 2.5.
In future if anyone needs to add an entry; supposedly 2.6; he would do so as per the 
sequence maintained.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/