Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751389AbbFAHde (ORCPT ); Mon, 1 Jun 2015 03:33:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33037 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751003AbbFAHdZ convert rfc822-to-8bit (ORCPT ); Mon, 1 Jun 2015 03:33:25 -0400 Date: Mon, 1 Jun 2015 09:33:22 +0200 From: Igor Mammedov To: Radim =?UTF-8?B?S3LEjW3DocWZ?= Cc: linux-kernel@vger.kernel.org, Darren Hart , platform-driver-x86@vger.kernel.org Subject: Re: [PATCH] pvpanic: handle missing _STA correctly Message-ID: <20150601093322.4ec8de60@nial.brq.redhat.com> In-Reply-To: <1432930732-16568-1-git-send-email-rkrcmar@redhat.com> References: <1432930732-16568-1-git-send-email-rkrcmar@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1531 Lines: 41 On Fri, 29 May 2015 22:18:52 +0200 Radim Krčmář wrote: > pvpanic was not properly detected when _STA was missing. > > ACPI 6.0 April 2015, 6.3.7 _STA (Status) > If a device object (including the processor object) does not have an > _STA object, then OSPM assumes that all of the above bits are set > (i.e., the device is present, enabled, shown in the UI, and > functioning). > > Not adhering to the specification made pvpanic dormant under QEMU 2.3. > > Suggested-by: Igor Mammedov > Signed-off-by: Radim Krčmář Reviewed-by: Igor Mammedov > --- > drivers/platform/x86/pvpanic.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/pvpanic.c b/drivers/platform/x86/pvpanic.c > index 073a90a63dbc..7b6860333267 100644 > --- a/drivers/platform/x86/pvpanic.c > +++ b/drivers/platform/x86/pvpanic.c > @@ -95,8 +95,7 @@ static int pvpanic_add(struct acpi_device *device) > acpi_status status; > u64 ret; > > - status = acpi_evaluate_integer(device->handle, "_STA", NULL, > - &ret); > + status = acpi_bus_get_status_handle(device->handle, &ret); > > if (ACPI_FAILURE(status) || (ret & 0x0B) != 0x0B) > return -ENODEV; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/