Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751665AbbFAHti (ORCPT ); Mon, 1 Jun 2015 03:49:38 -0400 Received: from wtarreau.pck.nerim.net ([62.212.114.60]:55090 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750936AbbFAHt2 (ORCPT ); Mon, 1 Jun 2015 03:49:28 -0400 Date: Mon, 1 Jun 2015 09:49:22 +0200 From: Willy Tarreau To: Frans Klaver Cc: starlight.2015q2@binnacle.cx, "linux-kernel@vger.kernel.org" , netdev Subject: Re: 2.6.32.66 tcp regression OOPs Message-ID: <20150601074922.GA28740@1wt.eu> References: <6.2.5.6.2.20150531210751.0722ad10@binnacle.cx> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1441 Lines: 50 Hi, On Mon, Jun 01, 2015 at 09:00:21AM +0200, Frans Klaver wrote: > [cc: Willy Tarreau] > > On Mon, Jun 1, 2015 at 3:26 AM, wrote: > > Hello, > > > > Apoligies if I have submitted to the wrong lists. > > > > Encountered a regression in > > 2.6.32.66 relative to 2.6.32.65. > > > > Crash eight minutes after boot. > > > > Will responded with additional details > > if the OOPS is not sufficent. > > > > Best Regards > > > > Did you bisect it? Eric Dumazet notified me that of something possibly similar due to a mistake I made when backporting a fix by hand. Please apply the following patch to see if it fixes the problem : diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c index 5339f066234b..d1e2895bb63c 100644 --- a/net/ipv4/tcp_output.c +++ b/net/ipv4/tcp_output.c @@ -2136,7 +2136,7 @@ void tcp_send_fin(struct sock *sk) */ if (tskb && (tcp_send_head(sk) || tcp_memory_pressure)) { coalesce: - TCP_SKB_CB(skb)->flags |= TCPCB_FLAG_FIN; + TCP_SKB_CB(tskb)->flags |= TCPCB_FLAG_FIN; TCP_SKB_CB(tskb)->end_seq++; tp->write_seq++; if (!tcp_send_head(sk)) { Thanks, Willy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/