Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751959AbbFAHuq (ORCPT ); Mon, 1 Jun 2015 03:50:46 -0400 Received: from smtp.citrix.com ([66.165.176.89]:22381 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751440AbbFAHui (ORCPT ); Mon, 1 Jun 2015 03:50:38 -0400 X-IronPort-AV: E=Sophos;i="5.13,531,1427760000"; d="scan'208";a="267698823" Message-ID: <556C0EC4.5050206@citrix.com> Date: Mon, 1 Jun 2015 09:50:28 +0200 From: =?windows-1252?Q?Roger_Pau_Monn=E9?= User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Bob Liu , CC: , , , , , , Subject: Re: [PATCH] drivers: xen-blkfront: blkif_recover: recheck feature-persistent References: <1432599094-22245-1-git-send-email-bob.liu@oracle.com> In-Reply-To: <1432599094-22245-1-git-send-email-bob.liu@oracle.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1057 Lines: 27 El 26/05/15 a les 2.11, Bob Liu ha escrit: > When migrate from !feature-persistent host to feature-persistent host, domU > still think new host/backend don't support persistent. > Dmesg like: > backed has not unmapped grant: 839 > backed has not unmapped grant: 773 > backed has not unmapped grant: 773 > backed has not unmapped grant: 773 > backed has not unmapped grant: 839 > > We should recheck whether the new backend support feature-persistent during > blkif_recover(). Right, we recheck for indirect-descriptors but not persistent grants. Do you think it makes sense to split the part of blkfront_connect that checks for optional features, like persistent grants, indirect descriptors and flush/barrier features to a separate function and call it from both blkfront_connect and blkif_recover? Roger. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/