Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752315AbbFAIbH (ORCPT ); Mon, 1 Jun 2015 04:31:07 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:31171 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751122AbbFAIbC (ORCPT ); Mon, 1 Jun 2015 04:31:02 -0400 Message-ID: <556C1834.8030606@oracle.com> Date: Mon, 01 Jun 2015 16:30:44 +0800 From: Bob Liu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: =?windows-1252?Q?Roger_Pau_Monn=E9?= CC: xen-devel@lists.xen.org, david.vrabel@citrix.com, justing@spectralogic.com, konrad.wilk@oracle.com, paul.durrant@citrix.com, julien.grall@citrix.com, boris.ostrovsky@oracle.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: xen-blkfront: blkif_recover: recheck feature-persistent References: <1432599094-22245-1-git-send-email-bob.liu@oracle.com> <556C0EC4.5050206@citrix.com> In-Reply-To: <556C0EC4.5050206@citrix.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1167 Lines: 32 On 06/01/2015 03:50 PM, Roger Pau Monn? wrote: > El 26/05/15 a les 2.11, Bob Liu ha escrit: >> When migrate from !feature-persistent host to feature-persistent host, domU >> still think new host/backend don't support persistent. >> Dmesg like: >> backed has not unmapped grant: 839 >> backed has not unmapped grant: 773 >> backed has not unmapped grant: 773 >> backed has not unmapped grant: 773 >> backed has not unmapped grant: 839 >> >> We should recheck whether the new backend support feature-persistent during >> blkif_recover(). > > Right, we recheck for indirect-descriptors but not persistent grants. > > Do you think it makes sense to split the part of blkfront_connect that > checks for optional features, like persistent grants, indirect > descriptors and flush/barrier features to a separate function and call > it from both blkfront_connect and blkif_recover? > Yep, that would be better. Thanks, -Bob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/