Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752114AbbFAJOV (ORCPT ); Mon, 1 Jun 2015 05:14:21 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:34686 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751165AbbFAJOO convert rfc822-to-8bit (ORCPT ); Mon, 1 Jun 2015 05:14:14 -0400 MIME-Version: 1.0 In-Reply-To: <556C2105.2090607@amd.com> References: <1433000370-19509-1-git-send-email-mikko.rapeli@iki.fi> <1433000370-19509-6-git-send-email-mikko.rapeli@iki.fi> <20150530164655.GM2067@n2100.arm.linux.org.uk> <556C15BA.7000909@amd.com> <20150601085605.GN2067@n2100.arm.linux.org.uk> <556C2105.2090607@amd.com> Date: Mon, 1 Jun 2015 11:14:12 +0200 Message-ID: Subject: Re: [PATCH 05/98] exynos_drm.h: use __u64 from linux/types.h From: Frans Klaver To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: Russell King - ARM Linux , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, Mikko Rapeli , Seung-Woo Kim , "linux-kernel@vger.kernel.org" , DRI mailing list , Kyungmin Park , Kukjin Kim , linux-api , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1075 Lines: 24 On Mon, Jun 1, 2015 at 11:08 AM, Christian König wrote: > Yeah, completely agree with Linus on the visibility problem and that's > exactly the reason why we don't include in the kernel header and > expect userspace to define the ISO types somewhere. > > But using the types from "include/linux/types.h" and especially including it > into the uapi headers doesn't make the situation better, but rather worse. > > With this step we not only make the headers depend on another header that > isn't part of the uapi, but also pollute the user space namespace with __sXX > and __uXX types which aren't defined anywhere else. These __uXX and __sXX types are defined in include/uapi/asm-generic/ll64.h and pulled in by include/uapi/linux/types.h. Including linux/types.h is therefore valid. Frans -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/