Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752128AbbFAJi2 (ORCPT ); Mon, 1 Jun 2015 05:38:28 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:57195 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751835AbbFAJiU (ORCPT ); Mon, 1 Jun 2015 05:38:20 -0400 Date: Mon, 1 Jun 2015 10:38:09 +0100 From: Russell King - ARM Linux To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: Mikko Rapeli , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, linux-api@vger.kernel.org, Seung-Woo Kim , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kyungmin Park , Kukjin Kim , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 05/98] exynos_drm.h: use __u64 from linux/types.h Message-ID: <20150601093808.GP2067@n2100.arm.linux.org.uk> References: <1433000370-19509-1-git-send-email-mikko.rapeli@iki.fi> <1433000370-19509-6-git-send-email-mikko.rapeli@iki.fi> <20150530164655.GM2067@n2100.arm.linux.org.uk> <556C15BA.7000909@amd.com> <20150601085605.GN2067@n2100.arm.linux.org.uk> <556C2105.2090607@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <556C2105.2090607@amd.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1687 Lines: 35 On Mon, Jun 01, 2015 at 11:08:21AM +0200, Christian K?nig wrote: > Yeah, completely agree with Linus on the visibility problem and that's > exactly the reason why we don't include in the kernel header and > expect userspace to define the ISO types somewhere. > > But using the types from "include/linux/types.h" and especially including it > into the uapi headers doesn't make the situation better, but rather worse. > > With this step we not only make the headers depend on another header that > isn't part of the uapi, but also pollute the user space namespace with __sXX > and __uXX types which aren't defined anywhere else. 1) Header files are permitted to pollute userspace with __-defined stuff. 2) __[su]XX types are defined as part of the kernel's uapi. include/uapi/linux/types.h includes asm/types.h, which in userspace picks up include/uapi/asm-generic/types.h. That picks up asm-generic/int-ll64.h, which defines these types. Moreover, this is done throughout the kernel headers _already_ (as you would expect for a policy set 10+ years ago). Please, I'm not interested in this discussion, so please don't argue with me - I may agree with your position, but what you think and what I think are really not relevant here. If you have a problem, take it up with Linus - I made that clear in my email. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/