Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752399AbbFALjN (ORCPT ); Mon, 1 Jun 2015 07:39:13 -0400 Received: from mail-lb0-f172.google.com ([209.85.217.172]:34482 "EHLO mail-lb0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752293AbbFALjB (ORCPT ); Mon, 1 Jun 2015 07:39:01 -0400 Message-ID: <556C4451.50503@cogentembedded.com> Date: Mon, 01 Jun 2015 14:38:57 +0300 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Jiang Liu , Thomas Gleixner , Bjorn Helgaas , Benjamin Herrenschmidt , Ingo Molnar , "H. Peter Anvin" , Randy Dunlap , Yinghai Lu , Borislav Petkov , Simon Horman , Magnus Damm CC: Konrad Rzeszutek Wilk , Tony Luck , x86@kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, linux-sh@vger.kernel.org Subject: Re: [Patch v3 11/36] sh, irq: Use helper irq_data_get_irq_handler_data() to hide irq_desc details References: <1433145945-789-1-git-send-email-jiang.liu@linux.intel.com> <1433145945-789-12-git-send-email-jiang.liu@linux.intel.com> In-Reply-To: <1433145945-789-12-git-send-email-jiang.liu@linux.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1610 Lines: 54 Hello. On 6/1/2015 11:05 AM, Jiang Liu wrote: > Use helper function irq_data_get_irq_handler_data() to hide irq_desc > implementation details. I'm only seeing calls to irq_{get|set}_handler_data() below... > Signed-off-by: Jiang Liu > --- > drivers/sh/intc/virq.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > diff --git a/drivers/sh/intc/virq.c b/drivers/sh/intc/virq.c > index f30ac9354ff2..bc0601cf0f8f 100644 > --- a/drivers/sh/intc/virq.c > +++ b/drivers/sh/intc/virq.c > @@ -83,12 +83,11 @@ EXPORT_SYMBOL_GPL(intc_irq_lookup); > > static int add_virq_to_pirq(unsigned int irq, unsigned int virq) > { > - struct intc_virq_list **last, *entry; > - struct irq_data *data = irq_get_irq_data(irq); > + struct intc_virq_list *entry; > + struct intc_virq_list **last = NULL; > > /* scan for duplicates */ > - last = (struct intc_virq_list **)&data->handler_data; > - for_each_virq(entry, data->handler_data) { > + for_each_virq(entry, irq_get_handler_data(irq)) { > if (entry->irq == virq) > return 0; > last = &entry->next; > @@ -102,7 +101,10 @@ static int add_virq_to_pirq(unsigned int irq, unsigned int virq) > > entry->irq = virq; > > - *last = entry; > + if (last) > + *last = entry; > + else > + irq_set_handler_data(irq, entry); > > return 0; > } WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/