Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753423AbbFAMDc (ORCPT ); Mon, 1 Jun 2015 08:03:32 -0400 Received: from mail-qc0-f182.google.com ([209.85.216.182]:35325 "EHLO mail-qc0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752785AbbFAMDD (ORCPT ); Mon, 1 Jun 2015 08:03:03 -0400 MIME-Version: 1.0 X-Originating-IP: [217.173.38.102] In-Reply-To: <1433122264-6702-1-git-send-email-jmmahler@gmail.com> References: <20150531235259.GA4620@hudson.localdomain> <1433122264-6702-1-git-send-email-jmmahler@gmail.com> Date: Mon, 1 Jun 2015 14:03:02 +0200 Message-ID: Subject: Re: [PATCH] fuse: avoid clobbering fc->release with fuse_conn_init(fc) From: Miklos Szeredi To: Jeremiah Mahler Cc: fuse-devel , Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1549 Lines: 44 On Mon, Jun 1, 2015 at 3:31 AM, Jeremiah Mahler wrote: > fuse_conn_init(fc) zeros the entire fc structure before it assigns > specific values. Since fc->release is set before fuse_conn_init(fc) > is called, the value gets set to zero, which results in a NULL pointer > deference when fc->release() is called. Fix the problem by assigning > fc->release after calling fuse_conn_init(fc) instead of before. I added this fix to the original patch and force pushed to fuse.git/for-next. Better keep it in one so that your fix is not left out accidentally when being backported to -stable. Thanks, Miklos > > Signed-off-by: Jeremiah Mahler > Fixes: daccc092d1a2 ("fuse: initialize fc->release before calling it") > --- > fs/fuse/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c > index 01ff55d..2913db2 100644 > --- a/fs/fuse/inode.c > +++ b/fs/fuse/inode.c > @@ -1076,8 +1076,8 @@ static int fuse_fill_super(struct super_block *sb, void *data, int silent) > if (!fc) > goto err_fput; > > - fc->release = fuse_free_conn; > fuse_conn_init(fc); > + fc->release = fuse_free_conn; > > fud = fuse_dev_alloc(fc); > if (!fud) > -- > 2.1.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/