Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753415AbbFAO03 (ORCPT ); Mon, 1 Jun 2015 10:26:29 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:36560 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751234AbbFAO0U (ORCPT ); Mon, 1 Jun 2015 10:26:20 -0400 Message-ID: <556C6B87.6080403@redhat.com> Date: Mon, 01 Jun 2015 16:26:15 +0200 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Xiao Guangrong CC: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/15] KVM: MTRR: introduce mtrr_for_each_mem_type References: <1432983566-15773-1-git-send-email-guangrong.xiao@linux.intel.com> <1432983566-15773-13-git-send-email-guangrong.xiao@linux.intel.com> <556C26D4.6030205@redhat.com> In-Reply-To: <556C26D4.6030205@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1427 Lines: 41 On 01/06/2015 11:33, Paolo Bonzini wrote: >> + looker->mem_type = looker->mtrr_state->fixed_ranges[index]; >> > + looker->start = fixed_mtrr_range_end_addr(seg, index); >> > + return true; > in mtrr_lookup_fixed_start is the same as this: > >> > >> > + end = fixed_mtrr_range_end_addr(looker->seg, looker->index); >> > + >> > + /* switch to next segment. */ >> > + if (end >= eseg->end) { >> > + looker->seg++; >> > + looker->index = 0; >> > + >> > + /* have looked up for all fixed MTRRs. */ >> > + if (looker->seg >= ARRAY_SIZE(fixed_seg_table)) >> > + return mtrr_lookup_var_start(looker); >> > + >> > + end = fixed_mtrr_range_end_addr(looker->seg, looker->index); >> > + } >> > + >> > + looker->mem_type = mtrr_state->fixed_ranges[looker->index]; >> > + looker->start = end; > in mtrr_lookup_fixed_next. Can you try to make them more common? > > Basically you should have > > +#define mtrr_for_each_mem_type(_looker_, _mtrr_, _gpa_start_, _gpa_end_) \ > + for (mtrr_lookup_init(_looker_, _mtrr_, _gpa_start_, _gpa_end_); \ > + !mtrr_lookup_end(_looker_); mtrr_lookup_next(_looker_)) ... where the above code I quoted would be part of mtrr_lookup_end. Paolo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/