Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753214AbbFAOh7 (ORCPT ); Mon, 1 Jun 2015 10:37:59 -0400 Received: from smtp37.i.mail.ru ([94.100.177.97]:48327 "EHLO smtp37.i.mail.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751507AbbFAOhv (ORCPT ); Mon, 1 Jun 2015 10:37:51 -0400 Message-ID: <556C6E2F.7050100@list.ru> Date: Mon, 01 Jun 2015 17:37:35 +0300 From: Stas Sergeev User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Jacek Anaszewski CC: linux-leds@vger.kernel.org, Linux kernel , Stas Sergeev , Bryan Wu , Richard Purdie , Kyungmin Park Subject: Re: [PATCH 01/20] leds: implement LED_BRIGHTNESS_FAST flag References: <555CA58A.10700@list.ru> <555CA5FA.2080308@list.ru> <556C1855.7070903@samsung.com> <556C4851.7060900@list.ru> <556C69EA.10000@samsung.com> In-Reply-To: <556C69EA.10000@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam: Not detected X-Mras: Ok Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 920 Lines: 17 01.06.2015 17:19, Jacek Anaszewski пишет: >> In fact, the things are more complicated: some drivers do small >> udelay()'s but do not use a work-queue. I was not marking them as >> FAST, although perhaps they could still be marked as SYNC? > This could be handled by adding a property to struct led_classdev > for defining minimum acceptable delay. Then FAST flag should not > be needed. Oh c'mon, that's too difficult! Lets just have a flag whether we can do an SW PWM from hrtimer irq callback. If we can't do from irq callback - simply do not do anything below 10mS. IMHO a simple and practical solution. Otherwise we'll not have anything implemented at all I guess. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/