Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752429AbbFAPf4 (ORCPT ); Mon, 1 Jun 2015 11:35:56 -0400 Received: from mx.binnacle.cx ([108.53.208.154]:36106 "EHLO mx.binnacle.cx" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751340AbbFAPfs (ORCPT ); Mon, 1 Jun 2015 11:35:48 -0400 Message-Id: <6.2.5.6.2.20150601113107.07232e78@binnacle.cx> Date: Mon, 01 Jun 2015 11:32:19 -0400 To: Willy Tarreau , Frans Klaver From: starlight.2015q2@binnacle.cx Subject: Re: 2.6.32.66 tcp regression OOPs Cc: "linux-kernel@vger.kernel.org" , netdev In-Reply-To: <20150601074922.GA28740@1wt.eu> References: <6.2.5.6.2.20150531210751.0722ad10@binnacle.cx> <20150601074922.GA28740@1wt.eu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" X-Spam-Score: -1 () ALL_TRUSTED Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1782 Lines: 68 Hi, I found the patch late yesterday and applied it. Running fine now for 12 hours under active load. Recommend the patch be rolled into the tarball, or a notation added to the release page as this one has severe consequences. Thank You! At 09:49 6/1/2015 +0200, Willy Tarreau wrote: >Hi, > >On Mon, Jun 01, 2015 at 09:00:21AM +0200, Frans Klaver wrote: >> [cc: Willy Tarreau] >> >> On Mon, Jun 1, 2015 at 3:26 AM, > wrote: >> > Hello, >> > >> > Apoligies if I have submitted to the wrong lists. >> > >> > Encountered a regression in >> > 2.6.32.66 relative to 2.6.32.65. >> > >> > Crash eight minutes after boot. >> > >> > Will responded with additional details >> > if the OOPS is not sufficent. >> > >> > Best Regards >> > >> >> Did you bisect it? > >Eric Dumazet notified me that of something possibly similar due to >a mistake I made when backporting a fix by hand. > >Please apply the following patch to see if it fixes the problem >: > >diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c > >index 5339f066234b..d1e2895bb63c 100644 > >--- a/net/ipv4/tcp_output.c >+++ b/net/ipv4/tcp_output.c >@@ -2136,7 +2136,7 @@ void tcp_send_fin(struct sock *sk) > */ > if (tskb && (tcp_send_head(sk) || tcp_memory_pressure)) { > coalesce: >- TCP_SKB_CB(skb)->flags |= TCPCB_FLAG_FIN; >+ TCP_SKB_CB(tskb)->flags |= TCPCB_FLAG_FIN; > TCP_SKB_CB(tskb)->end_seq++; > tp->write_seq++; > if (!tcp_send_head(sk)) { > >Thanks, >Willy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/