Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753514AbbFAQKL (ORCPT ); Mon, 1 Jun 2015 12:10:11 -0400 Received: from g9t5008.houston.hp.com ([15.240.92.66]:59964 "EHLO g9t5008.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753193AbbFAQJ4 (ORCPT ); Mon, 1 Jun 2015 12:09:56 -0400 Message-ID: <1433173815.23540.110.camel@misato.fc.hp.com> Subject: Re: [PATCH v11 2/12] x86, mm, pat: Refactor !pat_enabled handling From: Toshi Kani To: Borislav Petkov Cc: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, akpm@linux-foundation.org, arnd@arndb.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-nvdimm@ml01.01.org, jgross@suse.com, stefan.bader@canonical.com, luto@amacapital.net, hmh@hmh.eng.br, yigal@plexistor.com, konrad.wilk@oracle.com, Elliott@hp.com, mcgrof@suse.com, hch@lst.de Date: Mon, 01 Jun 2015 09:50:15 -0600 In-Reply-To: <20150531094655.GA20440@pd.tnic> References: <1432940350-1802-1-git-send-email-toshi.kani@hp.com> <1432940350-1802-3-git-send-email-toshi.kani@hp.com> <20150531094655.GA20440@pd.tnic> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1698 Lines: 42 On Sun, 2015-05-31 at 11:46 +0200, Borislav Petkov wrote: > On Fri, May 29, 2015 at 04:59:00PM -0600, Toshi Kani wrote: > > From: Toshi Kani > > > > This patch refactors the !pat_enabled code paths and integrates > > them into the PAT abstraction code. The PAT table is emulated by > > corresponding to the two cache attribute bits, PWT (Write Through) > > and PCD (Cache Disable). The emulated PAT table is the same as the > > BIOS default setup when the system has PAT but the "nopat" boot > > option is specified. The emulated PAT table is also used when > > MSR_IA32_CR_PAT returns 0 -- 9d34cfdf4796 ("x86: Don't rely on > > VMWare emulating PAT MSR correctly"). > > To be honest, I wasn't surprised when you sent me the same patch and > ignored most of my comments. For the future, please let me know if I'm > wasting my time with commenting on your stuff so that I can plan my work > and not waste time and energy reviewing, ok? I apologize that I overlooked a comment requesting to divide this refactor patch into smaller patches. > Unfortunately, if you want something done right, you have to do it > yourself. > > So I did that, I split that ugly cleanup into something much more > readable, patches as a reply to this message. > > Feel free to base your work ontop of > > git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git#tip-mm-2 > I will look into your changes, and rebase the patchset. Thanks, -Toshi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/