Message-ID: <1433176350.4861.21.camel@perches.com>
Subject: Re: [PATCHv4 2/2] mailbox: Adding driver for Xilinx LogiCORE IP
 mailbox.
From: Joe Perches <joe@perches.com>
To: Moritz Fischer <moritz.fischer@ettus.com>
Cc: jassisinghbrar@gmail.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org,
        pawel.moll@arm.com, mark.rutland@arm.com,
        ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
        michal.simek@xilinx.com, soren.brinkmann@xilinx.com,
        akpm@linux-foundation.org, gregkh@linuxfoundation.org,
        mchehab@osg.samsung.com, arnd@arndb.de, jingoohan1@gmail.com,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Date: Mon, 01 Jun 2015 09:32:30 -0700
In-Reply-To: <1433175507-3833-3-git-send-email-moritz.fischer@ettus.com>
References: <1433175507-3833-1-git-send-email-moritz.fischer@ettus.com>
	 <1433175507-3833-3-git-send-email-moritz.fischer@ettus.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1024
Lines: 34

On Mon, 2015-06-01 at 09:18 -0700, Moritz Fischer wrote:
> The Xilinx LogiCORE IP mailbox is a FPGA core that allows for
> interprocessor communication via AXI4 memory mapped / AXI4 stream
> interfaces.

trivia:

> diff --git a/drivers/mailbox/mailbox-xilinx.c b/drivers/mailbox/mailbox-xilinx.c
[]
> +static int xilinx_mbox_startup(struct mbox_chan *chan)
> +{
[]
> +			dev_err(mbox->dev,
> +				"failed to register mailbox interrupt:%d\n",
> +				ret);
[]
> +static int xilinx_mbox_probe(struct platform_device *pdev)
> +{
[]
> +		dev_err(&pdev->dev, "Couldn't get clk.\n");
[]
> +		dev_info(&pdev->dev, "IRQ not found, fallback to polling.\n");
[]
> +		dev_err(&pdev->dev, "Register mailbox failed\n");

Perhaps it' be nicer to consistently use a "no-period"
message style.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/