Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753469AbbFAQgU (ORCPT ); Mon, 1 Jun 2015 12:36:20 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:38008 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752691AbbFAQgK (ORCPT ); Mon, 1 Jun 2015 12:36:10 -0400 Date: Mon, 1 Jun 2015 17:36:04 +0100 From: Mark Brown To: Richard Fitzgerald Cc: patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, lgirdwood@gmail.com Message-ID: <20150601163604.GE14071@sirena.org.uk> References: <1433163891-10084-1-git-send-email-rf@opensource.wolfsonmicro.com> <20150601161047.GC14071@sirena.org.uk> <20150601162241.GA13681@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gm5TwAJMO0F2iVRz" Content-Disposition: inline In-Reply-To: <20150601162241.GA13681@opensource.wolfsonmicro.com> X-Cookie: The end of labor is to gain leisure. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v7 1/4] ASoC: arizona: Export functions to control subsystem DVFS X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1693 Lines: 44 --gm5TwAJMO0F2iVRz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jun 01, 2015 at 05:22:51PM +0100, Richard Fitzgerald wrote: > On Mon, Jun 01, 2015 at 05:10:47PM +0100, Mark Brown wrote: > > > + if (priv->dvfs_reqs) > > > + ret = arizona_dvfs_disable(codec); > > Are you sure that the function shouldn't check for requests? It seems > > like every caller is repeating the same check. > Sorry, I don't understand your comment here. When SYSCLK is disabled > we need to disable DVFS so that the codec can't go into suspend in the > illegal state of DVFS enabled but insifficient DCVDD. However, if > dvfs_reqs==0 DVFS is already disabled so we can save some time. Sure, but you repeat the same tests for dvfs_reqs at every call site which suggests it should be factored into the functions. --gm5TwAJMO0F2iVRz Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVbInzAAoJECTWi3JdVIfQTzEH/RIMCaBqF/UnCjbcMHf6CCG7 /rELoJLzm+lGaIJDoH1te60vl9h50FeNNFNwPPsGBmxURQ9UQhDypojJ4cRrxGDQ MDn+6b2sH0vSQOf1Nqhq1SOAmmfv5z3zZIQ5WU0FWRwHo7bXLgfqHEUWIKnduk9s Zncn9aRcJ5bFitTzclrfbxFcXS8owySa/r85XRyHFuObovPNSt7j2rFs3jBgd0dR 0h+HDOz67Di0KhaNmuNEftQTs2Qqx0GI+WHC8BvXN+UxEiWI9AZSY/8FpQPee2eS HNYNI0/mVfdKfwtR13oX0jfd9SJT41xXyKzTXXQFpArqGn+piDnFXdF2q141IrU= =DW0C -----END PGP SIGNATURE----- --gm5TwAJMO0F2iVRz-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/