Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753847AbbFAQlA (ORCPT ); Mon, 1 Jun 2015 12:41:00 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:43893 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753713AbbFAQkv (ORCPT ); Mon, 1 Jun 2015 12:40:51 -0400 Message-ID: <556C8B10.8040000@infradead.org> Date: Mon, 01 Jun 2015 09:40:48 -0700 From: Randy Dunlap User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: =?UTF-8?B?UGFsaSBSb2jDoXI=?= , Darren Hart CC: Jim Davis , Stephen Rothwell , linux-next , linux-kernel , platform-driver-x86@vger.kernel.org Subject: Re: randconfig build error with next-20150521, in drivers/platform/x86/dell-rbtn.c References: <20150521195615.GF22037@vmdeb7> <201505212207.11872@pali> In-Reply-To: <201505212207.11872@pali> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2259 Lines: 68 On 05/21/15 13:07, Pali Rohár wrote: > On Thursday 21 May 2015 21:56:15 Darren Hart wrote: >> On Thu, May 21, 2015 at 10:36:15AM -0700, Jim Davis wrote: >>> Building with the attached random configuration file, >>> >>> drivers/built-in.o: In function `rbtn_remove': >>> dell-rbtn.c:(.text+0x31d7f4): undefined reference to >>> `input_unregister_device' drivers/built-in.o: In function >>> `rbtn_notify': >>> dell-rbtn.c:(.text+0x31d8e5): undefined reference to `input_event' >>> dell-rbtn.c:(.text+0x31d8f8): undefined reference to `input_event' >>> dell-rbtn.c:(.text+0x31d911): undefined reference to `input_event' >>> dell-rbtn.c:(.text+0x31d924): undefined reference to `input_event' >>> drivers/built-in.o: In function `rbtn_add': >>> dell-rbtn.c:(.text+0x31da11): undefined reference to >>> `input_allocate_device' dell-rbtn.c:(.text+0x31da4a): undefined >>> reference to `input_register_device' dell-rbtn.c:(.text+0x31da5e): >>> undefined reference to `input_free_device' Makefile:938: recipe >>> for target 'vmlinux' failed >> >> Thanks Jim, >> >> Pali, the DELL_RBTN needs to ensure if it it's built-in, that INPUT >> is too. ... >> >>> CONFIG_INPUT=m >>> CONFIG_INPUT_FF_MEMLESS=m >>> CONFIG_INPUT_POLLDEV=m >>> CONFIG_INPUT_SPARSEKMAP=m >>> CONFIG_INPUT_MATRIXKMAP=m >> >> ... >> >>> CONFIG_DELL_RBTN=y >> >> Please submit a fix as a new patch. > > I believe that this patch is needed: > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index 8c03223..d025fd8 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -141,6 +141,7 @@ config DELL_SMO8800 > config DELL_RBTN > tristate "Dell Airplane Mode Switch driver" > depends on ACPI > + depends on INPUT > depends on RFKILL > ---help--- > Say Y here if you want to support Dell Airplane Mode Switch ACPI > > I did not tested it yet, but all other drivers depends on INPUT. > Acked-by: Randy Dunlap Please get the patch merged. Thanks. -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/