Message-ID: <1433177040.4861.25.camel@perches.com>
Subject: Re: [PATCH v2 1/3] megaraid : use dev_printk when possible
From: Joe Perches <joe@perches.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Kashyap Desai <kashyap.desai@avagotech.com>,
        Uday Lingala <uday.lingala@avagotech.com>,
        Sumit Saxena <sumit.saxena@avagotech.com>,
        "PDL,MEGARAIDLINUX" <megaraidlinux.pdl@avagotech.com>,
        "James E.J. Bottomley" <JBottomley@odin.com>,
        Christoph Hellwig <hch@lst.de>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Date: Mon, 01 Jun 2015 09:44:00 -0700
In-Reply-To: <CAErSpo7E85pFOj2FC8BRcbXrvWa3AMTTV2dhW1d=w5BX+POKVA@mail.gmail.com>
References: <20150601153240.23309.73917.stgit@bhelgaas-glaptop2.roam.corp.google.com>
	 <20150601154003.23309.70647.stgit@bhelgaas-glaptop2.roam.corp.google.com>
	 <1433175024.4861.11.camel@perches.com>
	 <CAErSpo7E85pFOj2FC8BRcbXrvWa3AMTTV2dhW1d=w5BX+POKVA@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1497
Lines: 37

On Mon, 2015-06-01 at 11:40 -0500, Bjorn Helgaas wrote:
> On Mon, Jun 1, 2015 at 11:10 AM, Joe Perches <joe@perches.com> wrote:
> > On Mon, 2015-06-01 at 10:40 -0500, Bjorn Helgaas wrote:
> >> Use dev_printk() when possible to make messages more useful.
> > []
> >> diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
> > []
> >> @@ -268,7 +268,7 @@ mega_query_adapter(adapter_t *adapter)
> >>               raw_mbox[2] = NC_SUBOP_PRODUCT_INFO;    /* i.e. 0x0E */
> >>
> >>               if ((retval = issue_scb_block(adapter, raw_mbox)))
> >> -                     printk(KERN_WARNING
> >> +                     dev_warn(&adapter->dev->dev,
> >>                       "megaraid: Product_info cmd failed with error: %d\n",
> >>                               retval);
> >
> > Wouldn't these be a bit redundant with a "megaraid: " prefix now?
> > Perhaps it'd be nicer to realign arguments too.
> 
> Yes, you're right.  I took out most of the "megaraid: " prefixes, but
> I missed a few.
> 
> I tried not to realign things too much because it's hard to know where
> to stop, and I don't want to spend a week on this.

;)  I try to realign all modified statements.

> I'll post a v3 in a day or two in case there are other comments.

Thanks.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/