Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753575AbbFAQyG (ORCPT ); Mon, 1 Jun 2015 12:54:06 -0400 Received: from mail-qc0-f176.google.com ([209.85.216.176]:35878 "EHLO mail-qc0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753484AbbFAQxz (ORCPT ); Mon, 1 Jun 2015 12:53:55 -0400 MIME-Version: 1.0 In-Reply-To: <1433177040.4861.25.camel@perches.com> References: <20150601153240.23309.73917.stgit@bhelgaas-glaptop2.roam.corp.google.com> <20150601154003.23309.70647.stgit@bhelgaas-glaptop2.roam.corp.google.com> <1433175024.4861.11.camel@perches.com> <1433177040.4861.25.camel@perches.com> From: Bjorn Helgaas Date: Mon, 1 Jun 2015 11:53:33 -0500 Message-ID: Subject: Re: [PATCH v2 1/3] megaraid : use dev_printk when possible To: Joe Perches Cc: Kashyap Desai , Uday Lingala , Sumit Saxena , "PDL,MEGARAIDLINUX" , "James E.J. Bottomley" , Christoph Hellwig , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1720 Lines: 38 On Mon, Jun 1, 2015 at 11:44 AM, Joe Perches wrote: > On Mon, 2015-06-01 at 11:40 -0500, Bjorn Helgaas wrote: >> On Mon, Jun 1, 2015 at 11:10 AM, Joe Perches wrote: >> > On Mon, 2015-06-01 at 10:40 -0500, Bjorn Helgaas wrote: >> >> Use dev_printk() when possible to make messages more useful. >> > [] >> >> diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c >> > [] >> >> @@ -268,7 +268,7 @@ mega_query_adapter(adapter_t *adapter) >> >> raw_mbox[2] = NC_SUBOP_PRODUCT_INFO; /* i.e. 0x0E */ >> >> >> >> if ((retval = issue_scb_block(adapter, raw_mbox))) >> >> - printk(KERN_WARNING >> >> + dev_warn(&adapter->dev->dev, >> >> "megaraid: Product_info cmd failed with error: %d\n", >> >> retval); >> > >> > Wouldn't these be a bit redundant with a "megaraid: " prefix now? >> > Perhaps it'd be nicer to realign arguments too. >> >> Yes, you're right. I took out most of the "megaraid: " prefixes, but >> I missed a few. >> >> I tried not to realign things too much because it's hard to know where >> to stop, and I don't want to spend a week on this. > > ;) I try to realign all modified statements. That's probably a reasonable approach. But it can also lead to inconsistent indentation in the file, e.g., printk args indented differently from args to other functions, which I don't like either. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/