Date: Mon, 1 Jun 2015 10:28:43 -0700
From: Jeremiah Mahler <jmmahler@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: fuse-devel <fuse-devel@lists.sourceforge.net>,
        Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fuse: avoid clobbering fc->release with
 fuse_conn_init(fc)
Message-ID: <20150601172843.GA24635@hudson.localdomain>
Mail-Followup-To: Jeremiah Mahler <jmmahler@gmail.com>,
	Miklos Szeredi <miklos@szeredi.hu>,
	fuse-devel <fuse-devel@lists.sourceforge.net>,
	Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <20150531235259.GA4620@hudson.localdomain>
 <1433122264-6702-1-git-send-email-jmmahler@gmail.com>
 <CAJfpegstSBEqu5QO1qWAsuoQAGUBXf3RmrKXg0P3oRiZ9EQfeA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJfpegstSBEqu5QO1qWAsuoQAGUBXf3RmrKXg0P3oRiZ9EQfeA@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1018
Lines: 27

Miklos,

On Mon, Jun 01, 2015 at 02:03:02PM +0200, Miklos Szeredi wrote:
> On Mon, Jun 1, 2015 at 3:31 AM, Jeremiah Mahler <jmmahler@gmail.com> wrote:
> > fuse_conn_init(fc) zeros the entire fc structure before it assigns
> > specific values.  Since fc->release is set before fuse_conn_init(fc)
> > is called, the value gets set to zero, which results in a NULL pointer
> > deference when fc->release() is called.  Fix the problem by assigning
> > fc->release after calling fuse_conn_init(fc) instead of before.
> 
> I added this fix to the original patch and force pushed to
> fuse.git/for-next.  Better keep it in one so that your fix is not left
> out accidentally when being backported to -stable.
> 
> Thanks,
> Miklos
> 

Good idea, thanks :-)

-- 
- Jeremiah Mahler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/