Date: Mon, 1 Jun 2015 18:55:13 +0100
From: Lee Jones <lee.jones@linaro.org>
To: Valentin Rothberg <valentinrothberg@gmail.com>
Cc: Andreas Ruprecht <andreas.ruprecht@fau.de>,
        Paul Bolle <pebolle@tiscali.nl>,
        hengelein Stefan <stefan.hengelein@fau.de>, wim@iguana.be,
        david.paris@st.com, linux-kernel@vger.kernel.org,
        linux-watchdog@vger.kernel.org
Subject: Re: watchdog: st_wdt: select on undefined MFD_ST_LPC
Message-ID: <20150601175513.GG3329@x1>
References: <CAD3Xx4JLanN3Luo1ijtPAA5LKz8fiWU=zs2SuCGvGn6JTMka_Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAD3Xx4JLanN3Luo1ijtPAA5LKz8fiWU=zs2SuCGvGn6JTMka_Q@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1135
Lines: 34

On Mon, 01 Jun 2015, Valentin Rothberg wrote:

> Hi Lee,
> 
> your commit d0c9e350b9a4 ("watchdog: st_wdt: Add new driver for ST's
> LPC Watchdog") is in today's linux-next tree (i.e., next-20150601) and
> adds the following lines of code to drivers/watchdog/Kconfig.
> 
> +config ST_LPC_WATCHDOG
> ...
> +       select MFD_ST_LPC
> 
> The select turns out to be a NOOP since MFD_ST_LPC is not defined
> Kconfig.  Is it the correct option to be selected?  I could not find a
> similar option in the source, nor get any hints  from searching the
> lkml.
> 
> I detected the issue with ./scripts/checkkconfigsymbols.py by diffing
> the last and today's linux tree.

You're right.  This symbol is legacy.  I will remove.

Thanks for reporting.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/