Message-ID: <1433196404.4089.187.camel@freescale.com>
Subject: Re: [v4] QE: Move QE from arch/powerpc to drivers/soc
From: Scott Wood <scottwood@freescale.com>
To: Zhao Qiang-B45475 <qiang.zhao@freescale.com>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "Xie Xiaobo-R63061" <X.Xie@freescale.com>
Date: Mon, 1 Jun 2015 17:06:44 -0500
In-Reply-To: <SN1PR0301MB1550F0744C4F5B84D6B6DA9D9BB60@SN1PR0301MB1550.namprd03.prod.outlook.com>
References: <1415763613-43674-1-git-send-email-B45475@freescale.com>
	 <20150130052208.GA14431@home.buserror.net>
	 <SN1PR0301MB1550F0744C4F5B84D6B6DA9D9BB60@SN1PR0301MB1550.namprd03.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2015 22:06:58.6204
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1483
X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1433;2:EaIVyGria8fJ9vbhtWC2GSfgqhm9LCvm+wGD6cmrgF2INSC2Z41J+A1Dv9qqp1Oh;2:BZLKTFKPCymPaN4yZ1dNlMY8wQn0SCXxlrVgeL92gseJ8RafXyfbSrZzeA7LrhXyqujVyrtTWDu9cqfTqBu7GN+vwCSctvLzsxy6pyDIcqzc5cwSEtp+NW6XoPudLLKA1qmGRr5VYJT+8MrY6aBxVA==;9:7MI7FAraiS6Q7ZKdeJaRMoQ0xx9px3HwqnHucbGU07PatIGfCcpqkaWr1uhTgnfiQfMOf0LEUi17PQw/6GA4+iVmy3TuL+FmBDxpr5mhjvQuCNCTYA2/+8Vf0ggEEUHr/6ofmLapbdfM/8yYnbShug==
X-OriginatorOrg: freescale.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1974
Lines: 54

On Sun, 2015-05-31 at 23:09 -0500, Zhao Qiang-B45475 wrote:
> On Fri, Jan 30, 2015 at 1:22PM +0800, Wood Scott wrote:
> 
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Friday, January 30, 2015 1:22 PM
> > To: Zhao Qiang-B45475
> > Cc: linux-kernel@vger.kernel.org; netdev@vger.kernel.org; linuxppc-
> > dev@lists.ozlabs.org; Wood Scott-B07421; Xie Xiaobo-R63061
> > Subject: Re: [v4] QE: Move QE from arch/powerpc to drivers/soc
> > 
> > On Wed, Nov 12, 2014 at 11:40:13AM +0800, Zhao Qiang wrote:
> > > ls1 has qe and ls1 has arm cpu.
> > > move qe from arch/powerpc to drivers/soc/fsl to adapt to powerpc 
> > > and
> > > arm
> > > 
> > > Signed-off-by: Zhao Qiang <B45475@freescale.com>
> > > ---
> > > Changes for v2:
> > >   - move code to driver/soc
> > > Changes for v3:
> > >   - change drivers/soc/qe to drivers/soc/fsl-qe Changes for v4:
> > >   - move drivers/soc/fsl-qe to drivers/soc/fsl/qe
> > >   - move head files for qe from include/linux/fsl to 
> > > include/soc/fsl
> > >   - move qe_ic.c to drivers/irqchip/
> > 
> > Need MAINTAINERS update for drivers/soc/fsl/qe, as previously 
> > discussed.
> 
> You mean, I need to finish the following work before move qe to 
> public directory?
> 
> 1. gpio.c -> needs to be converted to GPIO framework and placed in 
> drivers/gpio
> 2. qe_ic* should probably move into drivers/irqchip
> 3. qe_io.c should be converted over to pinmux and put in 
> drivers/pinctrl
> 4. Some of the clock could should be looked to be converted to use 
> the clk framework

Those would be nice but at the very least:
1. Don't introduce code into the toplevel /lib that duplicates 
existing functionality, and
2. Add a MAINTAINERS entry as described above

-Scott

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/