Date: Mon, 1 Jun 2015 17:48:38 -0700
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Wang Nan <wangnan0@huawei.com>
Cc: namhyung@kernel.org, masami.hiramatsu.pt@hitachi.com, acme@kernel.org,
        paulus@samba.org, a.p.zijlstra@chello.nl, mingo@redhat.com,
        jolsa@kernel.org, dsahern@gmail.com, daniel@iogearbox.net,
        brendan.d.gregg@gmail.com, lizefan@huawei.com, hekuang@huawei.com,
        xiakaixu@huawei.com, linux-kernel@vger.kernel.org, pi3orama@163.com
Subject: Re: [RFC PATCH v5 00/30] perf tools: filtering events using eBPF
 programs
Message-ID: <20150602004836.GA1700@Alexeis-MacBook-Pro.local>
References: <1433144296-74992-1-git-send-email-wangnan0@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1433144296-74992-1-git-send-email-wangnan0@huawei.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1073
Lines: 26

On Mon, Jun 01, 2015 at 07:37:46AM +0000, Wang Nan wrote:
> This is the 5th version of patch series which tries to introduce eBPF
> programs to perf. It enables 'perf record' to filter events using eBPF

thanks! As far as I could review this set addresses all of my earlier comments.

>  Patch 4/30 - 22/30 introduce libbpf, which first parse eBPF object
>    files then load maps and programs into kernel.

the libbpf side looks good.
For the patches that I haven't explictly acked yet:
Acked-by: Alexei Starovoitov <ast@plumgrid.com>

>  Patch 23-30 - 30/30 are perf side modifications, introducing
>    new syntax: '--event [.*].(o|bpf)' to enable passing eBPF object
>    files to 'perf record', create probing points and attach programs
>    to those points.

Looks good to me as well.
Arnaldo, please take a deep look :)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/