Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753065AbbFBG0f (ORCPT ); Tue, 2 Jun 2015 02:26:35 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:46891 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751514AbbFBG01 (ORCPT ); Tue, 2 Jun 2015 02:26:27 -0400 Message-ID: <556D4C73.7090202@huawei.com> Date: Tue, 2 Jun 2015 14:25:55 +0800 From: Hanjun Guo User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Jiang Liu , Thomas Gleixner , Bjorn Helgaas , "Benjamin Herrenschmidt" , Ingo Molnar , "H. Peter Anvin" , Randy Dunlap , Yinghai Lu , Borislav Petkov , "Catalin Marinas" , Will Deacon , Sudeep Holla , Marc Zyngier CC: Konrad Rzeszutek Wilk , Tony Luck , , , , , Subject: Re: [Patch v3 17/36] ARM64, irq: Use access helper irq_data_get_affinity_mask() References: <1433145945-789-1-git-send-email-jiang.liu@linux.intel.com> <1433145945-789-18-git-send-email-jiang.liu@linux.intel.com> In-Reply-To: <1433145945-789-18-git-send-email-jiang.liu@linux.intel.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.17.188] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.556D4C85.0028,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 36e520d27eabeb1dcc338583e2c24e7a Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1470 Lines: 44 On 2015/6/1 16:05, Jiang Liu wrote: > Use access helper irq_data_get_affinity_mask() to hide implementation > details of struct irq_desc. > > Signed-off-by: Jiang Liu > --- > arch/arm64/kernel/irq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kernel/irq.c b/arch/arm64/kernel/irq.c > index 240b75c0e94f..463fa2e7e34c 100644 > --- a/arch/arm64/kernel/irq.c > +++ b/arch/arm64/kernel/irq.c > @@ -61,7 +61,7 @@ void __init init_IRQ(void) > static bool migrate_one_irq(struct irq_desc *desc) > { > struct irq_data *d = irq_desc_get_irq_data(desc); > - const struct cpumask *affinity = d->affinity; > + const struct cpumask *affinity = irq_data_get_affinity_mask(d); > struct irq_chip *c; > bool ret = false; > > @@ -81,7 +81,7 @@ static bool migrate_one_irq(struct irq_desc *desc) > if (!c->irq_set_affinity) > pr_debug("IRQ%u: unable to set affinity\n", d->irq); > else if (c->irq_set_affinity(d, affinity, false) == IRQ_SET_MASK_OK && ret) > - cpumask_copy(d->affinity, affinity); > + cpumask_copy(irq_data_get_affinity_mask(d), affinity); > > return ret; > } Reviewed-by: Hanjun Guo Thanks Hanjun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/