Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755392AbbFBG7i (ORCPT <rfc822;w@1wt.eu>);
	Tue, 2 Jun 2015 02:59:38 -0400
Received: from ns.mm-sol.com ([37.157.136.199]:52505 "EHLO extserv.mm-sol.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752142AbbFBG7b (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 2 Jun 2015 02:59:31 -0400
Message-ID: <1433228366.6844.18.camel@mm-sol.com>
Subject: Re: [PATCH v2] drm/msm/hdmi: Use pinctrl in HDMI driver
From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: Stephane Viau <sviau@codeaurora.org>
Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org, robdclark@gmail.com
Date: Tue, 02 Jun 2015 09:59:26 +0300
In-Reply-To: <1433190528-30026-1-git-send-email-sviau@codeaurora.org>
References: <1433190528-30026-1-git-send-email-sviau@codeaurora.org>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.13.7-fta1.2~trusty 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1718
Lines: 44


Hi Stephane, 

On Mon, 2015-06-01 at 16:28 -0400, Stephane Viau wrote:
> Some targets (eg: msm8994) use the pinctrl framework to configure
> interface pins. This change adds support for initialization and
> pinctrl active/sleep state control for the HDMI driver.
> 
> Signed-off-by: Stephane Viau <sviau@codeaurora.org>
> ---
> v2:
> - Add devicetree binding documentation for pinctrl property  [Ivan]
> - Use pinctrl framework's PINCTRL_STATE_DEFAULT/SLEEP states [Ivan]
> 

<snip>

> 
>  static int hdmi_bind(struct device *dev, struct device *master, void *data)
> @@ -365,6 +379,7 @@ static int hdmi_bind(struct device *dev, struct device *master, void *data)
>  #ifdef CONFIG_OF
>         struct device_node *of_node = dev->of_node;
>         const struct of_device_id *match;
> +       struct pinctrl *pinctrl;
> 
>         match = of_match_node(dt_match, of_node);
>         if (match && match->data) {
> @@ -383,6 +398,18 @@ static int hdmi_bind(struct device *dev, struct device *master, void *data)
>         hdmi_cfg->mux_sel_gpio  = get_gpio(dev, of_node, "qcom,hdmi-tx-mux-sel");
>         hdmi_cfg->mux_lpm_gpio  = get_gpio(dev, of_node, "qcom,hdmi-tx-mux-lpm");
> 
> +       /* not all targets have pinctrl, do not fail in case of error: */
> +       pinctrl = devm_pinctrl_get(dev);

Probably I have to be more explicit. Why not using pins binding handled in driver
really_probe()? I have to admit that I am not familiar with DRM subsystem.

Regards,
Ivan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/