MIME-version: 1.0
Content-type: text/plain; charset=UTF-8; format=flowed
Content-transfer-encoding: 8BIT
Message-id: <556D6548.20905@samsung.com>
Date: Tue, 02 Jun 2015 10:11:52 +0200
From: Jacek Anaszewski <j.anaszewski@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804
 Thunderbird/17.0.8
To: Stas Sergeev <stsp@list.ru>
Cc: linux-leds@vger.kernel.org, Linux kernel <linux-kernel@vger.kernel.org>,
        Stas Sergeev <stsp@users.sourceforge.net>,
        Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>,
        Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH 01/20] leds: implement LED_BRIGHTNESS_FAST flag
References: <555CA58A.10700@list.ru> <555CA5FA.2080308@list.ru>
 <556C1855.7070903@samsung.com> <556C4851.7060900@list.ru>
 <556C69EA.10000@samsung.com> <556C6E2F.7050100@list.ru>
In-reply-to: <556C6E2F.7050100@list.ru>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1196
Lines: 27

On 06/01/2015 04:37 PM, Stas Sergeev wrote:
> 01.06.2015 17:19, Jacek Anaszewski пишет:
>>> In fact, the things are more complicated: some drivers do small
>>> udelay()'s but do not use a work-queue. I was not marking them as
>>> FAST, although perhaps they could still be marked as SYNC?
>> This could be handled by adding a property to struct led_classdev
>> for defining minimum acceptable delay. Then FAST flag should not
>> be needed.
> Oh c'mon, that's too difficult!
> Lets just have a flag whether we can do an SW PWM from hrtimer irq callback.
> If we can't do from irq callback - simply do not do anything below 10mS.
> IMHO a simple and practical solution.
> Otherwise we'll not have anything implemented at all I guess.
>

I agree if we are not going to mark the drivers using delays as FAST.
Otherwise the minimum acceptable value stemming from delay value
would be required. I prefer the former.

-- 
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/